Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up gulp task dependencies, fixes #1333 and #1334 #1336

Merged
merged 1 commit into from
Jun 29, 2017
Merged

clean up gulp task dependencies, fixes #1333 and #1334 #1336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ var analyticsDirectory = '../analytics';
var port = 9999;

// Tasks
gulp.task('default', ['clean', 'webpack']);
gulp.task('default', ['webpack']);

gulp.task('serve', ['clean', 'lint', 'build-bundle-dev', 'watch', 'test']);
gulp.task('serve', ['lint', 'build-bundle-dev', 'watch', 'test']);

gulp.task('serve-nw', ['clean', 'lint', 'devpack', 'webpack', 'watch', 'e2etest']);
gulp.task('serve-nw', ['lint', 'watch', 'e2etest']);

gulp.task('run-tests', ['clean', 'lint', 'webpack', 'test']);
gulp.task('run-tests', ['lint', 'test']);

gulp.task('build', ['build-bundle-prod']);

Expand Down Expand Up @@ -132,7 +132,7 @@ gulp.task('webpack', ['clean'], function () {
});

//zip up for release
gulp.task('zip', ['clean', 'webpack'], function () {
gulp.task('zip', ['webpack'], function () {
return gulp.src(['build/dist/*', 'integrationExamples/gpt/*'])
.pipe(zip(packageNameVersion + '.zip'))
.pipe(gulp.dest('./'));
Expand Down Expand Up @@ -222,7 +222,6 @@ gulp.task('watch', function () {
'loaders/**/*.js',
'test/spec/loaders/**/*.js'
], ['lint']);
gulp.watch(['integrationExamples/gpt/*.html'], ['test']);
connect.server({
https: argv.https,
port: port,
Expand Down Expand Up @@ -252,7 +251,7 @@ gulp.task('docs', ['clean-docs'], function () {
.pipe(gulp.dest('docs'));
});

gulp.task('e2etest', function() {
gulp.task('e2etest', ['devpack', 'webpack'], function() {
var cmdQueue = [];
if(argv.browserstack) {
var browsers = require('./browsers.json');
Expand Down