Fix import and module reference #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
reviewed
Jul 12, 2017
| @@ -466,7 +466,7 @@ exports.insertPixel = function (url) { | |||
| } catch (e) { | |||
| } | |||
| }; | |||
| this.insertElement(img); | |||
| exports.insertElement(img); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
For the record.... most of the functions in this file actually do this. I fixed a couple in the video cache PR too.
Some are easy to fix, but some aren't. Not sure which category insertElement is in, or how deep down the rabbit hole you want this to go... or if we should just file a ticket and schedule the time to fix them all.
There was a problem hiding this comment.
Updated the other insertElement reference as well. I'd like to go through utils and update remaining this references at some point, or convert to ES module syntax entirely, but for now just scoped this PR to insertElement references
dbemiller
previously approved these changes
Jul 12, 2017
* Use 'exports' for other insertElement reference
matthewlane
force-pushed
the
bugfix/imptrack-function-import
branch
from
d45b696
to
b721d95
Compare
dbemiller
approved these changes
Jul 12, 2017
mkendall07
approved these changes
Jul 12, 2017
jbAdyoulike
pushed a commit
to jbAdyoulike/Prebid.js
that referenced
this pull request
Sep 21, 2017
* Use 'exports' for other insertElement reference
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Use 'exports' for other insertElement reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixes function that was being imported as a default, but wasn't a default export. Also updates util references so that exported functions work when imported with ES module syntax