Concurrent auctions for Prebid 1.0 #1421
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| import Adapter from 'src/adapter'; | ||
| import { Renderer } from 'src/Renderer'; | ||
| import bidfactory from 'src/bidfactory'; | ||
| import * as utils from 'src/utils'; | ||
| import { ajax } from 'src/ajax'; | ||
| import { STATUS } from 'src/constants'; | ||
|
|
@@ -36,7 +35,7 @@ function AppnexusAstAdapter() { | |
| let usersync = false; | ||
|
|
||
| /* Prebid executes this function when the page asks to send out bid requests */ | ||
| baseAdapter.callBids = function(bidRequest, addBidResponse, done) { | ||
| bidRequests = {}; | ||
|
|
||
| const bids = bidRequest.bids || []; | ||
|
|
@@ -150,72 +149,80 @@ function AppnexusAstAdapter() { | |
| contentType: 'text/plain', | ||
| withCredentials: true | ||
| }); | ||
|
|
||
| /* Notify Prebid of bid responses so bids can get in the auction */ | ||
| // Disabled lint for no-inner declaration error | ||
| /*eslint-disable */ | ||
|
There was a problem hiding this comment. How sure are you that this is safe? Linter errors usually exist for good reason, and know better than the average programmer. This one looks like it exists because it's not legal ES5. Does our babel/webpack transform it into code which is ES5 compliant? If you've done the research and are certain it's safe, disable it globally in the If (like me) you're too lazy for that, you could also just fix the code by declaring it like |
||
| function handleResponse(response) { | ||
| let parsed; | ||
|
|
||
| try { | ||
| parsed = JSON.parse(response); | ||
| } catch (error) { | ||
| utils.logError(error); | ||
| } | ||
|
|
||
| if (!parsed || parsed.error) { | ||
| let errorMessage = `in response for ${baseAdapter.getBidderCode()} adapter`; | ||
| if (parsed && parsed.error) { errorMessage += `: ${parsed.error}`; } | ||
| utils.logError(errorMessage); | ||
|
|
||
| // signal this response is complete | ||
| Object.keys(bidRequests) | ||
| .map(bidId => bidRequests[bidId].placementCode) | ||
| .forEach(placementCode => { | ||
| addBidResponse(placementCode, createBid(STATUS.NO_BID), auctionId); | ||
|
There was a problem hiding this comment.
There'll be far fewer bugs that way. |
||
| done(); | ||
| }); | ||
| return; | ||
| } | ||
|
|
||
| parsed.tags.forEach(tag => { | ||
| const ad = getRtbBid(tag); | ||
| const cpm = ad && ad.cpm; | ||
| const type = ad && ad.ad_type; | ||
|
|
||
| let status; | ||
| if (cpm !== 0 && (SUPPORTED_AD_TYPES.includes(type))) { | ||
| status = STATUS.GOOD; | ||
| } else { | ||
| status = STATUS.NO_BID; | ||
| } | ||
|
|
||
| if (type && (!SUPPORTED_AD_TYPES.includes(type))) { | ||
| utils.logError(`${type} ad type not supported`); | ||
| } | ||
|
|
||
| tag.bidId = tag.uuid; // bidfactory looks for bidId on requested bid | ||
| const bid = createBid(status, tag); | ||
| if (type === 'native') bid.mediaType = 'native'; | ||
| if (type === 'video') bid.mediaType = 'video'; | ||
| if (ad && ad.renderer_url) bid.mediaType = 'video-outstream'; | ||
|
|
||
| if (bid.adId in bidRequests) { | ||
| const placement = bidRequests[bid.adId].placementCode; | ||
| const auctionId = bidRequests[bid.adId].auctionId; | ||
| addBidResponse(placement, bid, auctionId); | ||
| } | ||
| }); | ||
|
|
||
| if (!usersync) { | ||
| const iframe = utils.createInvisibleIframe(); | ||
| iframe.src = '//acdn.adnxs.com/ib/static/usersync/v3/async_usersync.html'; | ||
| try { | ||
| document.body.appendChild(iframe); | ||
| } catch (error) { | ||
| utils.logError(error); | ||
| } | ||
| usersync = true; | ||
| } | ||
| done(); | ||
| } | ||
| /*eslint-enable */ | ||
| } | ||
| }; | ||
|
|
||
|
|
||
|
|
||
| /* Check that a bid has required paramters */ | ||
| function valid(bid) { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as you're rewriting these... you might want to check out the format proposed by @snapwich
Other adapter maintainers are going to look to these for inspiration... so setting a good pattern will pay dividends in maintenance.