+ Add Optimatic Bid Adapter #1837
Conversation
There was a problem hiding this comment.
Hey @optimatic58,
This generally looks good... but there's one blocker. I left a comment about it below.
modules/optimaticBidAdapter.js
Outdated
| }; | ||
| } | ||
|
|
||
| function log (field1, field2, field3, field4, pct) { |
There was a problem hiding this comment.
I see what you're trying to do here... but right now Prebid doesn't have a good way to support things like this. Ajax calls are expensive, and will interfere with both the auction and the publisher's page load performance.
Ideally, we'd offer Adapters some way to "defer" work until the critical page loading stuff is done. For now, could you remove this from the code and add your use-case(s) to #1762?
We're trying to collect use cases for now so we can support it in a more general way.
There was a problem hiding this comment.
We have made and committed the changes requested. Please let us know if there is anything else. Thank you!
+ replaced "partnerId" with correct "placement" parameter name
* unstream/master: (36 commits) + Add Optimatic Bid Adapter (prebid#1837) Add Bridgewell adapter (prebid#1825) Kumma adapter updated for Prebid 1.0 (prebid#1766) Touchup add bid response (prebid#1822) Fix skipped test (prebid#1836) Added new size in Rubicon pbjs Adapter (prebid#1842) HuddledMasses header bidding adapter (prebid#1806) Increment pre version Prebid 0.33.0 Release Update AOL adapter for v1.0 (prebid#1693) Sovrn 1.0 compliance (prebid#1796) Platform.io Bidder Adapter update (prebid#1817) Drop non-video bidders from video ad units (prebid#1815) Update renderAd to replace ${AUCTION_PRICE} in adUrl (prebid#1795) Pulsepoint adapter: fixing bid rejection due to missing mandatory bid params. (prebid#1823) Remove require.ensure entirely (prebid#1816) Add custom keyword support for pbs bid adapter (prebid#1763) OpenX Video Adapter update to Prebid v1.0 (prebid#1724) Fix test that hard-coded pbjs global. (prebid#1786) Update Pollux Adapter to v1.0 (prebid#1694) ...
* + Add Optimatic Bid Adapter * + cleaned up player log ajax call (as requested) + replaced "partnerId" with correct "placement" parameter name * + commit again
* + Add Optimatic Bid Adapter * + cleaned up player log ajax call (as requested) + replaced "partnerId" with correct "placement" parameter name * + commit again
Type of change
Description of change
Add Optimatic Bid Adapter
Other information