GumGum Adapter for Prebid.js 1.0 #1966

mxcoder · 2017-12-15T00:56:09Z

Type of change

New bidder adapter

Description of change

GumGum Adapter according to 1.0 rules

test parameters for validating bids

{
  bidder: 'gumgum',
  params: {
    inSlot: '9'
  }
}

contact email of the adapter’s maintainer
[email protected]
official adapter submission

Other information

We already had a GumGum Adapter integrated, this is just to upgrade to 1.0
CC @bruscantini

mxcoder · 2017-12-21T22:14:37Z

Hi @matthewlane and prebid team members, just wondering if you have any info on the time window in which we could see these reviewed/merged? We know holidays are here, but just to manage expectations on our end.

Thanks

matthewlane · 2017-12-21T22:22:25Z

Hi @mxcoder, many of us are out until the new year, and we plan to ramp back up with full PR reviews and other work in January. Thank you for your pull request and for your patience

mxcoder · 2017-12-21T22:37:04Z

Excellent, thanks a lot @matthewlane . Have a great holiday season.

mike-chowla · 2018-01-03T23:58:37Z

With provided test params, no ad displays.

The issue is due to the price coming back as zero. Even though the zero bid wins the prebid auction, DFP is not selecting the ad. If I hack the price higher, the ad renders.

Request:
https://g2.gumgum.com/hbid/imp?si=9&pi=3&vw=1479&vh=272&sw=1920&sh=1080&pu=http%3A%2F%2Fmike.pubmatic.com%3A9999%2FintegrationExamples%2Fgpt%2Fhello_world.html%3Fpbjs_debug%3Dtrue&ce=true&dpr=1&

Response:
{"ad":{"id":29593,"width":300,"height":250,"ipd":2000,"markup":"<div style=\"width:298px;height:248px;background:#fff;display:block;border:1px solid #000;background:#fff url(https://c.gumgum.com/images/logo/all300.png) no-repeat scroll center center\">\n<\/div>","ii":true,"du":null,"price":0,"zi":0,"impurl":"http://ca-g2.gumgum.com/ad/view/enc/hasR4Y3aDoKInNYRxCfOp-Uatqav0e1WD5G7kBz28TPH_FI449l6geYihxmDbqkBwToLOroJBD8SkTOO_3-HoDBFm10IWp16dPzbpg5B3of-PtAu3cxrjdK4-4tOgMEe51OJok4Wqa4wR9LJVmrMqtxqobqryL2-KCm4tbWGbmo8vMZCy-heOj3YHMv35pzSaq_n2CHze-VbuROJ9mnZwrb63DJ4tTxteW30RaP85-E?c=0","clsurl":"http://ca-g2.gumgum.com/ad/close?si=9&t=ggumtest&ab=29593&pv=&pu=http%3A%2F%2Fmike.pubmatic.com%3A9999%2FintegrationExamples%2Fgpt%2Fhello_world.html%3Fpbjs_debug%3Dtrue&lt=&to=&ts=1515023714357&er=0E-10"},"pag":{"t":"ggumtest","css":"#GGID ._gBadge._g.Badge {\n z-index: 1000 !important;\n}\n\n/* DB-4066 */\nhtml { overflow-y: auto }","js":"G.infoFlag = 'japan';\n/* GG-18932 */\nG.samplerate = 100;\nG.loadObj('https://c.gumgum.com/libs/GG-18932.min.js',{type:'s',cb:false});\n/* AT-5020 */\nG.perfSampleRate = 100;\nconsole.log(\"environment\", env);"},"thms":10000,"cw":"<img src=\"https://c.gumgum.com/px.gif\" onload=\"(function(a,b){b.src='https://js.gumgum.com/gumgum.js',a.parentNode.replaceChild(b,a)})(this,document.createElement('script'))\"><gumgum-ad product=\"3\" fromAS='AD_JSON'><\/gumgum-ad>"}

mike-chowla · 2018-01-04T00:12:01Z

User syncs are broken and causing 404s.

The user sync url is being set to a fixed string:
url: 'ADAPTER_SYNC_URL'

Which causes the browser to load 'ADAPTER_SYNC_URL' relative to the current path which 404s

bruscantini · 2018-01-04T21:17:36Z

Hi @mike-chowla . Thanks for the feedback. For the test params, what adjustments would you recommend? Do you think this would require non-zero price values to be returned by our ad server all the time? I guess what I'm asking is whether there can be anything done on the adapter side to "hack" the price value for the test unit, or if the change would have to be done on our server side.

mike-chowla · 2018-01-04T23:01:24Z

The clean way to do this is to use a non-zero price coming back from the ad server.

…r test unit so DFP chooses it.

bruscantini · 2018-01-06T00:41:10Z

Thanks @mike-chowla . I opted to make the change in the adapter as doing so on the ad server was not as simple as I'd hoped.

mike-chowla · 2018-01-09T01:52:51Z

Your isTestUnit check is failing because it expects the si field to be an integer but it's a string (at least when using the test parameters)

This fixes the check:

-  let isTestUnit = (bidRequest.data && bidRequest.data.pi === 3 && bidRequest.data.si === 9)
+  let isTestUnit = (bidRequest.data && bidRequest.data.pi === 3 && bidRequest.data.si === "9")

bruscantini · 2018-01-09T02:27:28Z

Nice catch! Updated.

mike-chowla

With changes, LGTM

Test failure is shown but it's unrelated to this code and tests pass on my machine.

matthewlane · 2018-01-17T23:16:02Z

modules/gumgumBidAdapter.js

+      // dealId: DEAL_ID,
+      // referrer: REFERER,
+      ad: wrapper ? getWrapperCode(wrapper, Object.assign({}, serverResponseBody, { bidRequest })) : markup,
+      bidderCode: spec.code,


bidderCode will be set automatically by bidderFactory now, this line can be dropped

matthewlane · 2018-01-17T23:32:25Z

modules/gumgumBidAdapter.js

+    cw: wrapper
+  } = serverResponseBody
+  let isTestUnit = (bidRequest.data && bidRequest.data.pi === 3 && bidRequest.data.si === 9)
+  let [width, height] = bidRequest.sizes[0]


ad unit sizes may be defined as a double array ([[300, 250]]) or single array ([300, 250]). This will break if the size is defined as a single array, but utils.parseSizesInput can help account for either case. Something like utils.parseSizesInput(bidRequest.sizes)[0].split('x') if you only want the first size in the list

…t.sizes to account for 1-dimensional array.

bruscantini · 2018-01-18T02:24:55Z

thanks @matthewlane . Updated based on your suggestions.

matthewlane · 2018-01-18T19:31:50Z

@mxcoder @bruscantini This is merged to master. Please also submit a PR to update your bidder file in the docs repo, to add the line prebid_1_0_supported : true to the header, and make any updates to the bidder params if necessary

* 'master' of https://github.com/prebid/Prebid.js: (23 commits) Update Atomx adapter for Prebid v1.0 (prebid#2026) Add vi bid adapter (prebid#2020) Add eplanningBidAdapter (prebid#2003) OpenX Adapter: Update to support mediaTypes field, instead of the deprecated mediaType field (prebid#1974) Separate bids & won calls (prebid#2015) 1.0 adapter support for mantis (prebid#1840) Media.net adapter added (prebid#2038) GumGum Adapter for Prebid.js 1.0 (prebid#1966) Serverbid Bid Adapter: updated docs and ad sizes (prebid#2023) Adding districtm as an alias (prebid#2018) Use sudo to workaround Travis regression (prebid#2041) Fix uncached video bids triggering callback early (prebid#2017) Re-implemented RhythmOne audit beacon in prebid 1.0 interface (prebid#1953) Add NasmediaAdmixer adapter for Perbid.js 1.0 (prebid#1937) Update Adform adapter to Prebid v1.0 (prebid#1947) Upgrade Admixer adapter for Prebid 1.0 (prebid#1755) multiformat size validation checks (prebid#1964) Gjirafa Bidder Adapter (prebid#1944) pin gulp-connect at non-broken version (prebid#2008) Added dynamic ttl property for One Display and One Mobile. (prebid#2004) ...

* GumGum Adapter for Prebid.js 1.0 * removed getUserSyncs. Give cpm a non-zero value when bidRequest is for test unit so DFP chooses it. * parsing slot ID as integer from params * ADSS-78 removed bidderCode from response. Correctly parsing bidRequest.sizes to account for 1-dimensional array.

rmloveland · 2018-01-31T19:14:13Z

Added the needs-docs label since it's not showing up on http://prebid.org/download.html in the 1.2.0 dropdown due to lack of the page having the "prebid 1.0 support" key in the page's YAML header.

mxcoder · 2018-02-01T17:37:13Z

Thanks, we're working on this. We'll send another PR.

GumGum Adapter for Prebid.js 1.0

37935fe

matthewlane added the needs review label Jan 2, 2018

matthewlane requested a review from mike-chowla January 3, 2018 00:10

matthewlane assigned mike-chowla Jan 3, 2018

removed getUserSyncs. Give cpm a non-zero value when bidRequest is fo…

21dbae5

…r test unit so DFP chooses it.

parsing slot ID as integer from params

961f81e

mike-chowla approved these changes Jan 10, 2018

View reviewed changes

mike-chowla added LGTM and removed needs review labels Jan 10, 2018

matthewlane reviewed Jan 17, 2018

View reviewed changes

matthewlane assigned matthewlane and unassigned mike-chowla Jan 17, 2018

matthewlane added the needs update label Jan 17, 2018

ADSS-78 removed bidderCode from response. Correctly parsing bidReques…

b53be80

…t.sizes to account for 1-dimensional array.

matthewlane approved these changes Jan 18, 2018

View reviewed changes

matthewlane removed the needs update label Jan 18, 2018

matthewlane merged commit f09865b into prebid:master Jan 18, 2018

rmloveland added the needs docs label Jan 31, 2018

lbenmore deleted the ADSS-78-prebid-1.0 branch January 4, 2022 17:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GumGum Adapter for Prebid.js 1.0 #1966

GumGum Adapter for Prebid.js 1.0 #1966

mxcoder commented Dec 15, 2017

mxcoder commented Dec 21, 2017

matthewlane commented Dec 21, 2017

mxcoder commented Dec 21, 2017

mike-chowla commented Jan 3, 2018

mike-chowla commented Jan 4, 2018

bruscantini commented Jan 4, 2018 •

edited

Loading

mike-chowla commented Jan 4, 2018

bruscantini commented Jan 6, 2018

mike-chowla commented Jan 9, 2018 •

edited

Loading

bruscantini commented Jan 9, 2018

mike-chowla left a comment

matthewlane Jan 17, 2018

matthewlane Jan 17, 2018

bruscantini commented Jan 18, 2018

matthewlane commented Jan 18, 2018

rmloveland commented Jan 31, 2018

mxcoder commented Feb 1, 2018

GumGum Adapter for Prebid.js 1.0 #1966

GumGum Adapter for Prebid.js 1.0 #1966

Conversation

mxcoder commented Dec 15, 2017

Type of change

Description of change

Other information

mxcoder commented Dec 21, 2017

matthewlane commented Dec 21, 2017

mxcoder commented Dec 21, 2017

mike-chowla commented Jan 3, 2018

mike-chowla commented Jan 4, 2018

bruscantini commented Jan 4, 2018 • edited Loading

mike-chowla commented Jan 4, 2018

bruscantini commented Jan 6, 2018

mike-chowla commented Jan 9, 2018 • edited Loading

bruscantini commented Jan 9, 2018

mike-chowla left a comment

Choose a reason for hiding this comment

matthewlane Jan 17, 2018

Choose a reason for hiding this comment

matthewlane Jan 17, 2018

Choose a reason for hiding this comment

bruscantini commented Jan 18, 2018

matthewlane commented Jan 18, 2018

rmloveland commented Jan 31, 2018

mxcoder commented Feb 1, 2018

bruscantini commented Jan 4, 2018 •

edited

Loading

mike-chowla commented Jan 9, 2018 •

edited

Loading