Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

33across Bid Adapter: Bugfix + Refactor #2024

Merged
merged 11 commits into from
Feb 6, 2018
Merged

33across Bid Adapter: Bugfix + Refactor #2024

merged 11 commits into from
Feb 6, 2018

Conversation

curlyblueeagle
Copy link
Contributor

@curlyblueeagle curlyblueeagle commented Jan 10, 2018 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

  • Fixed how creativeId was being interpreted in response. It was incorrectly looking for it in bidder ext
  • Added test mode which will guarantee a bid response (real or test) and thus help regression test better
  • Fixed lint errors in tests
  • Removed ability to set test url via parameters.
  • test parameters for validating bids
{
  bidder: '33across',
  params: {
    siteId: 'aRlI5W_9yr5jkxacwqm_6r',
    productId: 'inpage',
    test: 1
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
    [email protected]

  • official adapter submission

Other information

curlyblueeagle and others added 11 commits November 7, 2017 10:04
@harpere harpere self-requested a review January 12, 2018 05:12
@harpere harpere self-assigned this Jan 12, 2018
@mkendall07 mkendall07 added this to the Prebid 1.3 release milestone Jan 24, 2018
jaiminpanchal27
jaiminpanchal27 approved these changes Feb 6, 2018
View reviewed changes
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewlane matthewlane merged commit aee2ef0 into prebid:master Feb 6, 2018
Millerrok pushed a commit to Vertamedia/Prebid.js that referenced this pull request Feb 12, 2018
Merge branch 'master' of https://github.com/prebid/Prebid.js
511e124 
* 'master' of https://github.com/prebid/Prebid.js: (51 commits)
  Update maintainer email (prebid#2132)
  Replace event string with constant (prebid#2128)
  Add adapter for IAS (prebid#2056)
  Fix sovrn dealid (prebid#2119)
  Added support for NURL and ADM as backup (prebid#2112)
  fix bug where hooked functions w/ no hooks weren't ran immediately (prebid#2115)
  Increment pre version
  Prebid 1.3.1 Release
  Omit app and device if not present rather than send false (prebid#2116)
  Increment pre version
  Prebid.js 1.3.0 Release
  Unit test fixes (prebid#2111)
  must explicitly list pre1api for it to be included in build (prebid#2097)
  adkernel adapter additional bid parameters (prebid#2105)
  removing userSync (prebid#2032)
  33across Bid Adapter: Bugfix + Refactor (prebid#2024)
  Port calling order fix to 1.x  (prebid#2067)
  Update adform adapter request (prebid#2107)
  Serverbid Bid Adapter: getUserSyncs and new adsizes (prebid#2106)
  Add hfa and pv parameter to request payload (prebid#2109)
  ...
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@curlyblueeagle @dluxemburg
33across Bid Adapter: Bugfix + Refactor (prebid#2024)
65d4b88 
* Adding 33across adapter

* Updated per code review from Prebid. See prebid#1805 (review)

* Added support for test bid and crid.

* Removed ability to set test url via params

* Incorporated changes requested in prebid#1855 to fix usage of deprecated method
@curlyblueeagle curlyblueeagle mentioned this pull request Jul 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

@matthewlane matthewlane matthewlane approved these changes

@harpere harpere Awaiting requested review from harpere

Assignees

@harpere harpere

Labels
LGTM
Projects
None yet
Milestone
Prebid 1.3 release
Development

Successfully merging this pull request may close these issues.
5 participants
@curlyblueeagle @matthewlane @jaiminpanchal27 @mkendall07 @harpere