Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional param to bridgewellBidAdapter #2289

Merged
merged 8 commits into from
Mar 21, 2018
Merged

add optional param to bridgewellBidAdapter #2289

merged 8 commits into from
Mar 21, 2018

Conversation

wuleo
Copy link
Contributor

@wuleo wuleo commented Mar 20, 2018

Type of change

  • Feature
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

Add parameter cpmWeight that allows publisher to alter (scale) bid prices from Bridgewell.

@jsnellbaker jsnellbaker self-requested a review March 20, 2018 17:21
@jsnellbaker jsnellbaker self-assigned this Mar 20, 2018
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @wuleo ,

Overall this PR looks good, however I did see one thing that should be altered. Can you please make the change when you get the chance?

Just to mention, I had some difficulty initially testing out the changes with the hello_world page using the test params in the updated md file. It turns out the base CPM for the test ad ($0.17) coupled with the 0.5 cpmWeight was causing the recalculated cpm to be below $0.10 - which was causing it to fall to the bottom tier price bucket which only had house ads.

Once I raised the cpmWeight setting (to 0.75 as an example), I was consistently seeing the test ad fine. Perhaps it would be ideal to adjust the test value in the md file?

Thanks.

@@ -82,7 +100,8 @@ export const spec = {
}

bidResponse.requestId = req.bidId;
bidResponse.cpm = matchedResponse.cpm;
bidResponse.requestId = req.bidId;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this duplicate line.

@wuleo
Copy link
Contributor Author

wuleo commented Mar 21, 2018

Some publishers in Taiwan may use this optional cpmWeight to prefer or not prefer Bridgewell’s bid price.
For instance, if a publisher set cpmWeight 0.5, this means they don’t want to prefer Bridgewell, they scale down Bridgewell’s bid price to 50% i.e. 0.5*(Bridgewell’s bid price).
In the other hand, if they set cpmWeight 1.5, it means they want to scale up Bridgewell’s bid price 50%, i.e. 1.5*(Bridgewell’s bid price).

@jsnellbaker
Copy link
Collaborator

@wuleo That's fine, it'll be up to the publisher to set the value that makes sense given their needs. I just wanted to comment on test params data in case it needs to be tested later on without difficulty. The changes look good now so I'll merge them in.

@jsnellbaker jsnellbaker merged commit 4226643 into prebid:master Mar 21, 2018
@wuleo
Copy link
Contributor Author

wuleo commented Mar 21, 2018

Thanks for the review. Very appreciate your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants