Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test fixes #2301

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Unit test fixes #2301

merged 1 commit into from
Mar 20, 2018

Conversation

jaiminpanchal27
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

Unit test fixes in IE and Safari Browsers

Other information

@lovell @Nistenf @sebaperez

expect(buildRequests([{
bidder,
bidId: requestId,
sizes: [[300, 250]],
params: { placementId }
}])[0].data).to.contain('&cb=');

Object.defineProperty(navigator, 'userAgent', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh this is pretty nasty.

@jaiminpanchal27 jaiminpanchal27 merged commit 8aec362 into master Mar 20, 2018
@matthewlane matthewlane deleted the fix-unit-tests branch March 27, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants