Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if cache markup is not enabled, set it to the default value 0 #2302

Merged
merged 2 commits into from
Mar 26, 2018
Merged

if cache markup is not enabled, set it to the default value 0 #2302

merged 2 commits into from
Mar 26, 2018

Conversation

moonshells
Copy link
Contributor

Type of change

  • Bugfix

Description of change

Parse cacheMarkup into the expected values (1 for Mobile App, 2 for Web), and if it is unsuccessful, defaults to 0

@jsnellbaker jsnellbaker self-assigned this Mar 21, 2018
@jsnellbaker jsnellbaker self-requested a review March 21, 2018 15:03
jsnellbaker
jsnellbaker approved these changes Mar 21, 2018
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaiminpanchal27 jaiminpanchal27 merged commit 4012c7e into prebid:master Mar 26, 2018
@moonshells moonshells deleted the add_cachemarkup_default_value branch March 26, 2018 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

Assignees

@jaiminpanchal27 jaiminpanchal27

@jsnellbaker jsnellbaker

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moonshells @jaiminpanchal27 @jsnellbaker