Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: vuble adapter handles dealId #2322

Merged
merged 2 commits into from
Apr 3, 2018

Conversation

Roffray
Copy link
Contributor

@Roffray Roffray commented Mar 28, 2018

Type of change

  • Feature

Description of change

The vuble adapter now handles the dealId returned by the response.

@jsnellbaker jsnellbaker self-assigned this Apr 2, 2018
@jsnellbaker jsnellbaker self-requested a review April 2, 2018 15:19
@jsnellbaker
Copy link
Collaborator

Hi @Roffray,
I was trying to test out the changes you made, but I wasn't getting a normal bid response from your system using the test data in md file for your adapter. Below is a copy of the response I saw in the console:
{"status":"ko"}

Can you take a look at this and let me know if there's something I should alter for my setup? Thanks!

@mifefr
Copy link
Contributor

mifefr commented Apr 3, 2018

Hi @jsnellbaker,
sorry the test ad had been turned off. I've put it back on you should see it now.

Geoffray

@jsnellbaker
Copy link
Collaborator

jsnellbaker commented Apr 3, 2018

Hi @mifefr I'm still getting the same response as before.

If it helps, below is a copy of the request made by the adapter:
{"width":"640","height":"480","pub_id":"3","zone_id":"12345","context":"instream","floor_price":5,"url":"http://www.vuble.tv/","env":"net","bid_id":"2f137af0eac824"}

@Roffray
Copy link
Contributor Author

Roffray commented Apr 3, 2018

Sorry, that's my bad. The pub_id was wrong.

I changed the pub_id from 3 to 18 in the md file in the MR. It now matches the one in the http://prebid.org/dev-docs/bidders.html page of the website.

Geoffray

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update to the test params info. I was seeing the video ad deliver fine and the dealId change was looking good.

@jsnellbaker jsnellbaker merged commit b633478 into prebid:master Apr 3, 2018
@Roffray Roffray deleted the vuble-adapter-handle-dealid branch December 13, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants