-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EngageBDR legacy bid adapter #2329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jlzhangdev Thanks for submitting this adapter in the legacy branch. The code for the present files looks good and seems to be working through my tests.
However, we would need to have some unit tests included for a new adapter. Could you put a test file together and include it in this PR? We should be good to go at that point.
Thanks!
Hi @jsnellbaker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding the unit tests.
Type of change
Description of change
Initial commit of our legacy bid adapter
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
prebid/prebid.github.io#685
Other information
1.x Bid adapter have been submit #2309