Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EngageBDR legacy bid adapter #2329

Merged
merged 6 commits into from
Apr 11, 2018
Merged

EngageBDR legacy bid adapter #2329

merged 6 commits into from
Apr 11, 2018

Conversation

jlzhangdev
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

Initial commit of our legacy bid adapter

  • test parameters for validating bids
{
  bidder: 'ebdr',
            params: {
               zoneid: '99999',
               bidfloor: '1.00',
               IDFA:'xxx-xxx',
               ADID:'xxx-xxx',
               latitude:'34.089811',
               longitude:'-118.392805'
            }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

prebid/prebid.github.io#685

Other information

1.x Bid adapter have been submit #2309

@jsnellbaker jsnellbaker self-assigned this Apr 2, 2018
@jsnellbaker jsnellbaker self-requested a review April 2, 2018 15:34
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jlzhangdev Thanks for submitting this adapter in the legacy branch. The code for the present files looks good and seems to be working through my tests.

However, we would need to have some unit tests included for a new adapter. Could you put a test file together and include it in this PR? We should be good to go at that point.

Thanks!

@jlzhangdev
Copy link
Contributor Author

Hi @jsnellbaker
We just finish add test case here. I hope it is good to go. :)

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the unit tests.

@jsnellbaker jsnellbaker merged commit aa32519 into prebid:legacy Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants