-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytic Adaptor by YuktaMedia #2392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shrikantpatwari LGTM, one minor change is needed
adUnitCode: bid.adUnitCode, | ||
requestId: bid.bidderRequestId, | ||
auctionId: bid.auctionId, | ||
pubcid: bid.crumbs.pubcid, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add check if bid.crumbs
exists or not. This can throw error
Please submit a PR to the docs repo to add a file for your analytics adapter to the analytics page so your analytics adapter's will appear on the analytics for prebid page. Thank you for contributing |
* Analytic Adaptor by YuktaMedia * removed optional bid request params * test case modified
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information