-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubicon adapter GDPR support #2406
Rubicon adapter GDPR support #2406
Conversation
@idettman This pull-request appears to be pulling in changes not related to GDPR in the file diff. Might need to be rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idettman The adapter file changes look fine. But it seems there are conflicts now in the PR against master.
Can you please review and address the conflicts, as well as comment on Rich's feedback? Thanks.
@idettman Also, can you submit a docs-PR to update the Rubicon bidders page with a new variable named This would allow the Rubicon adapter to show-up automatically on a list we have setup for GDPR supported adapters in the docs. Thanks. |
@jsnellbaker here's a link to the PR with |
@idettman Thanks for submitting the docs PR. When the other Rubicon GDPR PR was merged, it seems like it created some additional conflicts here. Can you please take a look again and see if we can get in sync with master? atm a number of changes look like they're going to be reverted in master if we were to merge as is. Thanks. |
2ab5e8e
to
097320a
Compare
Merged changes to latest master updates |
modules/rubiconBidAdapter.js
Outdated
// add GDPR properties if enabled | ||
if (config.getConfig('consentManagement')) { | ||
if (bidRequest.gdprConsent && typeof bidRequest.gdprConsent === 'object') { | ||
if (typeof bidRequest.gdprConsent.consentRequired === 'boolean') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idettman In the upcoming changes to the consentManagement module, we'll be renaming this field to bidderRequest.gdprConsent.gdprApplies
Can you please make the necessary changes to point to the new field? Please also ensure you're pointing to the bidderRequest
object and not the bidRequest
object.
As a final request, can you please make the above updates on the earlier set of GDPR code in the adapter file (for the video requests)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes are committed.
…hanged containing object used to access gdprConsent values (bidRequest -> bidderRequest)
What happens if the consent is not asked to the user? What's the default used by Rubicon? |
* Merged gdpr tests for banner bid requests * Renamed the gdprConsent.consentRequired to gdprConsent.gdprApplies. Changed containing object used to access gdprConsent values (bidRequest -> bidderRequest)
Type of change
Description of change
Updates the Rubicon adapter to:
Other information
Documentation update: prebid.github.io #719 | Task HB-2303