adding yieldbot adapter #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -97,7 +97,8 @@ var RubiconAdapter = function RubiconAdapter() { | |||
|
|
|||
| } | |||
|
|
|||
| pbjs.handleRubiconCallback = function(response) { | |||
| window.pbjs = window.pbjs || {que: []}; | |||
There was a problem hiding this comment.
Good catch. Could you refactor this into the first line of src/prebid.js - since this is an issue with pbjs being undefined other adapters could also have this issue. Thanks!
There was a problem hiding this comment.
yeah I'll take this out of here and put in a separate PR for that
|
To integrate this, will we have to use the yieldbot line items in the configuration? or is it going to reuse the ones prebid uses for some of his adapters? |
|
@ialex this uses the standard prebid line items/the |
marian-r
added a commit
to aol/Prebid.js
that referenced
this pull request
Nov 2, 2016
…MP-73-false-timed-out-bids to release/1.3.1 * commit '07315b6725a442dd26ee748174cd018949c05010': Refactoring, code cleanup Fixed reporting of timed out bids in AOL analytics
ChrisHuie
pushed a commit
that referenced
this pull request
Dec 5, 2023
* add Rise adapter * fixes * change param isOrg to org * Rise adapter * change email for rise * fix circle failed * bump * bump * bump * remove space * Upgrade Rise adapter to 5.0 * added isWrapper param * addes is_wrapper parameter to documentation * added is_wrapper to test * removed isWrapper * Rise Bid Adapter: support Coppa param (#24) * MinuteMedia Bid Adapter: support Coppa param (#25) * Revert "MinuteMedia Bid Adapter: support Coppa param (#25)" (#26) This reverts commit 66c4e7b. * bump * update coppa fetch * setting coppa param update * update Coppa tests * update test naming * Rise Bid Adapter: support plcmt and sua (#27) * update minuteMediaBidAdapter - support missing params (#29) * RIseBidAdapter: support currency (#35) --------- Co-authored-by: Noam Tzuberi <[email protected]> Co-authored-by: noamtzu <[email protected]> Co-authored-by: Noam Tzuberi <[email protected]> Co-authored-by: Laslo Chechur <[email protected]> Co-authored-by: OronW <[email protected]> Co-authored-by: lasloche <[email protected]> Co-authored-by: inna <[email protected]> Co-authored-by: YakirLavi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5 - set this up as a basic integration, using
yieldbot.getSlotCriteria