Prebid Auctions #386
Closed
Prebid Auctions #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
protonate
force-pushed
the
prebid-auctions
branch
from
e3f54b5
to
f858ae0
Compare
|
@mkendall07 for discussion |
This was referenced Jun 7, 2016
|
What's the story with the "on hold" label? |
|
@nedstankus |
The Prebid Auction is introduced, making it possible to manage a series of auction events. Previously Prebid handled only one auction at a time. With this PR the `pbjs.adUnits` and `pbjs.bidderSettings` are moved to an `auction` instance. Auctions can be run concurrently, so for example if different groupings of ad placements have different configurations, auctions for each placement group can both be requested at page load and run asynchronously. Be aware that if multiple auctions are run concurrently for the same placement the last auction winner creative will replace any previous winner.
protonate
force-pushed
the
prebid-auctions
branch
from
f858ae0
to
64dcd6d
Compare
| bidmanager.addBidResponse(bids[i].placementCode, adResponse); | ||
| } else { | ||
| // Indicate an ad was not returned | ||
| adResponse = bidfactory.createBid(2); |
There was a problem hiding this comment.
Need to pass bid ID for requested bid here.
|
We are going to close this PR and handling the concurrent bid request issue by queuing requests rather than creating auction instances. This keeps the singleton architecture of Prebid.js, at least for now, and we will work with each bidder team towards the changes needed within each adapter to achieve auction instances if that is defined as a roadmap priority by the Prebid Core Team. Issues #333 and #360 will be accommodated by the bid request queue approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prebid Auctions are implemented which enables instances of Prebid requests, responses and ad renders. This PR also includes the API changes needed to make concurrent requests for multiple placements, to queue up the next set of placements (for example, in an image carousel app) and to connect bid requests with bid responses across auction instances for greater level of analytics details.