Trion gdpr and usp consent #4740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rebid version(1.0).
…an up/consistency of tests.
… the test that requires it
…that we didn't account for. Changing adapter to account for response body and required params.
…release that we didn't account for. Changing adapter to account for response body and required params." This reverts commit 324d157.
…that we didn't account for. Changing adapter to account for response body and required params.
…ab is not visible.
…ginal form after tests.
…nt objects in tests.
# Conflicts: # modules/trionBidAdapter.js # test/spec/modules/trionBidAdapter_spec.js
…nction for page url for 3.0 release
|
also submitted documentation pull request at prebid/prebid.github.io#1752 |
bretg
approved these changes
Jan 16, 2020
|
LGTM, but please try re-running the CircleCI unit tests to get them to pass. |
@bretg we had this issue with circleci build checks not passing on here in the past with our pull requests. We do not have a browser stack account to run this against so the error I'm getting in the build is 'Username is required'. |
|
I opened a CircleCI support ticket to get to the bottom of why some PRs (like this one) end up outside of Prebid's CircleCI account. The response was: On your CircleCI project's screen, click "unfollow" on the Prebid.js row for your fork:
|
|
@bretg Thanks for the info! I didn't realize it was associating our fork to the circleCi project. The tests all pass now. |
hellsingblack
pushed a commit
to SublimeSkinz/Prebid.js
that referenced
this pull request
Mar 5, 2020
* Adding files associated with the trion adapter update to the newest prebid version(1.0). * Updating pull request with safer checks for user sync and general clean up/consistency of tests. * removing a call to bidder code for pull request review. also removing the test that requires it * there were some changes to the bid factory after our initial release that we didn't account for. Changing adapter to account for response body and required params. * Revert "there were some changes to the bid factory after our initial release that we didn't account for. Changing adapter to account for response body and required params." This reverts commit 324d157. * there were some changes to the bid factory after our initial release that we didn't account for. Changing adapter to account for response body and required params. * adding safety checks to Trion adapter * Sending up to trion endpoint if there is bot traffic or the browser tab is not visible. * sending the wrong param in the test. * Trion test cleanup. returning document and window states to their original form after tests. * Trion test cleanup. using before and after to alter window and document objects in tests. * re-adding trion adapter to prebid project to stop using deprecated function for page url for 3.0 release * minor formatting change * accept size array from media types banner over the sizes array from pubs. * updating trion bid adapter to be us privacy and gdpr compliant * encoding consent strings for test
1 task
8 tasks
|
This is happening to me. Stopped following but I can't see an option to follow the "real" project. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Updating Trion to comply with gdpr and usp consent