-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support min &max duration for onevideo #5079
Support min &max duration for onevideo #5079
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some work:
- fix setting properties on
undefined
- fix example in
.md
file
Also, could you, please, update PR description, it looks to me like a default template you get when you are opening new PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeepthiNeeladri You branch has conflicts, so you would need to resolve them before merging.
I'm not 100% sure why you have conflicts, it could be because you 'want to merge 44 commits', maybe squashing those commits into single commit will help with the conflicts.
* outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * comment * changes * min max dduration * .md file * min max * md change * version * tests fix Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]>
* 'master' of https://github.com/prebid/Prebid.js: (102 commits) Marsmedia - Add vastXml and fix id response (prebid#5067) PubMatic adapter to support image sync (prebid#5104) minor consentManagement fix (prebid#5050) fix circle ci failing tests (prebid#5113) Add Relaido Adapter (prebid#5101) Add new bid adapter for ConnectAd (prebid#4806) change payload (prebid#5105) Utils updates (prebid#5092) Read OpenRTB app objects if set in config + bug fix for when ad units are reloaded (prebid#5086) Criteo : added first party data mapping to bidder request (prebid#4954) updateAdGenerationManual (prebid#5032) New bid adapter: Wipes (prebid#5051) Prebid manager analytics utm tags (prebid#4998) CRITEO RTUS Integration with Yieldmo Prebid (prebid#5075) isSafariBrowser update (prebid#5077) Support min &max duration for onevideo (prebid#5079) increment pre version Prebid 3.15.0 release prebid#5011 Fix to set Secure attribute on cookie when SameSite=none (prebid#5064) Prebid adapter for windtalker (prebid#5040) ...
* outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * comment * changes * min max dduration * .md file * min max * md change * version * tests fix Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]> Co-authored-by: Deepthi Neeladri Sravana <[email protected]>
Type of change
Description of change
Adding Min and Max Duration Param support
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information