Add Supply Supply Chain Object Module support for Yieldlab Adapter #5521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirkorean
changed the title
msm0504
suggested changes
Aug 3, 2020
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I'll integrate your request changes soon, busy days with TCF2. Removing the stale flag with this comment hopefully? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
mirkorean
force-pushed
the
schain_pr
branch
from
14f5a3b
to
47a4e14
Compare
|
@msm0504 Thanks you for your review. I'm sorry for the delay here, but i finally came around to look into your and integrate your comments. Hope this lgty now :) |
msm0504
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Support for the Supply Chain Object Module (http://prebid.org/dev-docs/modules/schain.html). We want to serialize the bid.schain object according to: https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/supplychainobject.md#serialization-of-an-openrtb-supplychain-object-into-a-url-parameter
[email protected]