-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native support to ablida Bid Adapter #5545
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@jsnellbaker Can you reopen the PR? Is there an issue? |
Hi @bokos I just reopened the PR. I'll take a look at it today and follow-up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bokos
I took a look through the updates here and I think they mostly look good.
When I tried the test bid (using the params in the md file), I did notice that the mediaType
was banner
instead of native
. Based on the bid response that came from the endpoint, you'll need to specify this property in the intrepretResponse
function yourself, otherwise, Prebid will always assume the incoming bid is a banner
.
In addition, you'll want to submit a docs PR to update your bidder file to show you support native
. The page to update is here and you'll just need to update the media_types
field to banner, native
With these two updates, you should be good to go. Please let me know if you have any questions about the above. Thanks!
@jsnellbaker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the update. LGTM
* add onBidWon function, add bidder adapter version to bid requests * add support for native * use triggerPxel instead of ajax, because ajax was called 3 times with native
This reverts commit 6464877.
Type of change
Description of change
Add native support to ablida bid adapter
[email protected]
official adapter submission
Link to PR on the docs repo: Add native support in ablida docs prebid.github.io#2164