Pubperf analytics adapter added. #5550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs PR: prebid/prebid.github.io#2166 |
Fawke
requested changes
Jul 31, 2020
There was a problem hiding this comment.
Hi @doubaokun,
Thanks for the PR. I've gone through the code and it looks alright. I just have one question.
Why aren't you using passing global and handler to the analytics interface call. Instead of overriding the track function, you can make your code a lot more shorter. Refer to appnexusAnalyticsAdapter.js to get more context on this.
And, can you please make your test coverage at least 80 percent? Currently it's 66.67%
|
@Fawke Thanks for the review, the code is updated based on the suggestion. Test coverage is increased above 80%. |
Fawke
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
New prebid.js analytics adapter.
[email protected]
Other information