Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated a4g adapter #5688

Merged
merged 2 commits into from
Sep 7, 2020
Merged

Updated a4g adapter #5688

merged 2 commits into from
Sep 7, 2020

Conversation

Junus
Copy link
Contributor

@Junus Junus commented Sep 2, 2020

Type of change

  • Bugfix

Description of change

removed deprecated function

  • contact email of the adapter’s maintainer
    [email protected]

  • official adapter submission

Copy link
Contributor

@FilipStamenkovic FilipStamenkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this adapter was removed because it didn't comply with pbjs 3.0 release.

Also, I see some things are fixed, but not all of them. I left comments what else needs to be fixed.

Take a look at Adapter Maintainers Action Required described here.

modules/a4gBidAdapter.js Outdated Show resolved Hide resolved
modules/a4gBidAdapter.js Outdated Show resolved Hide resolved
@Junus
Copy link
Contributor Author

Junus commented Sep 7, 2020

Thanks, @FilipStamenkovic, updated PR

Copy link
Contributor

@FilipStamenkovic FilipStamenkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FilipStamenkovic FilipStamenkovic merged commit 783a3bb into prebid:master Sep 7, 2020
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
* Updated a4g adapter

* use https and mediaTypes sizes
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants