Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add video ad support to ablida bid adapter #5782

Merged
merged 11 commits into from
Sep 25, 2020
Merged

Add video ad support to ablida bid adapter #5782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4025ebb
add onBidWon function, add bidder adapter version to bid requests
bokos May 19, 2020
62dd4d0
Merge branch 'master' of github.com:prebid/Prebid.js
bokos Jul 24, 2020
6723626
add support for native
bokos Jul 24, 2020
2959f16
Merge remote-tracking branch 'upstream/master'
bokos Jul 28, 2020
c20d3a7
use triggerPxel instead of ajax, because ajax was called 3 times with…
bokos Jul 28, 2020
b5a16c1
Merge branch 'master' of github.com:prebid/Prebid.js into master
bokos Sep 2, 2020
7f987b0
add gdpr consent to bid requests
bokos Sep 2, 2020
9c70efe
Merge branch 'master' of github.com:prebid/Prebid.js into master
bokos Sep 16, 2020
a0e834d
update tests
bokos Sep 16, 2020
b2faa26
Merge branch 'master' of github.com:prebid/Prebid.js into master
bokos Sep 23, 2020
990f830
add video ad support
bokos Sep 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions modules/ablidaBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import * as utils from '../src/utils.js';
import {config} from '../src/config.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';
import { BANNER, NATIVE } from '../src/mediaTypes.js';
import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js';

const BIDDER_CODE = 'ablida';
const ENDPOINT_URL = 'https://bidder.ablida.net/prebid';

export const spec = {
code: BIDDER_CODE,
supportedMediaTypes: [BANNER, NATIVE],
supportedMediaTypes: [BANNER, NATIVE, VIDEO],

/**
* Determines whether or not the given bid request is valid.
Expand All @@ -35,6 +35,8 @@ export const spec = {
let sizes = []
if (bidRequest.mediaTypes && bidRequest.mediaTypes[BANNER] && bidRequest.mediaTypes[BANNER].sizes) {
sizes = bidRequest.mediaTypes[BANNER].sizes;
} else if (bidRequest.mediaTypes[VIDEO] && bidRequest.mediaTypes[VIDEO].playerSize) {
sizes = bidRequest.mediaTypes[VIDEO].playerSize
}
const jaySupported = 'atob' in window && 'currentScript' in document;
const device = getDevice();
Expand All @@ -46,7 +48,7 @@ export const spec = {
referer: bidderRequest.refererInfo.referer,
jaySupported: jaySupported,
device: device,
adapterVersion: 4,
adapterVersion: 5,
mediaTypes: bidRequest.mediaTypes,
gdprConsent: bidderRequest.gdprConsent
};
Expand Down
16 changes: 16 additions & 0 deletions modules/ablidaBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,22 @@ Module that connects to Ablida's bidder for bids.
}
}
]
}, {
code: 'video-ad',
mediaTypes: {
video: {
playerSize: [[640, 360]],
context: 'instream'
}
},
bids: [
{
bidder: 'ablida',
params: {
placementId: 'instream-demo'
}
}
]
}
];
```
2 changes: 1 addition & 1 deletion test/spec/modules/ablidaBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ describe('ablidaBidAdapter', function () {
method: 'POST',
url: ENDPOINT_URL,
data: {
adapterVersion: 4,
adapterVersion: 5,
bidId: '2b8c4de0116e54',
categories: undefined,
device: 'desktop',
Expand Down