Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversant adapter: add adomain, remove digitrust #6495

Merged
merged 16 commits into from
Mar 31, 2021
Merged

Conversant adapter: add adomain, remove digitrust #6495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c2f2046
Update eids.js
patmmccann Mar 25, 2021
c422dc9
Update eids_spec.js
patmmccann Mar 25, 2021
ec752ee
Update eids.js
patmmccann Mar 25, 2021
ea44e21
Update pubmaticBidAdapter_spec.js
patmmccann Mar 25, 2021
d44f298
Update eids.js
patmmccann Mar 25, 2021
10efcdd
Update eids_spec.js
patmmccann Mar 25, 2021
78fb35f
Update conversantBidAdapter_spec.js
patmmccann Mar 25, 2021
5c082a1
Update rubiconBidAdapter_spec.js
patmmccann Mar 25, 2021
09741b0
Update conversantBidAdapter_spec.js
patmmccann Mar 25, 2021
f42f6d8
Delete test/spec/adapters directory
patmmccann Mar 25, 2021
35de176
Update userId_spec.js
patmmccann Mar 25, 2021
afb73de
Update conversantBidAdapter.js
patmmccann Mar 29, 2021
155df12
Update conversantBidAdapter_spec.js
patmmccann Mar 29, 2021
7f9bcb7
Merge pull request #1 from prebid/master
patmmccann Mar 29, 2021
b1d6bf4
Update conversantBidAdapter_spec.js
patmmccann Mar 29, 2021
8a55c7d
Update conversantBidAdapter_spec.js
patmmccann Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modules/conversantBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,10 @@ export const spec = {
ttl: 300,
netRevenue: true
};
bid.meta = {};
if (conversantBid.adomain && conversantBid.adomain.length > 0) {
bid.meta.advertiserDomains = conversantBid.adomain;
}

if (request.video) {
if (responseAd.charAt(0) === '<') {
Expand Down Expand Up @@ -331,7 +335,6 @@ function collectEids(bidRequests) {
'criteo.com': 1,
'id5-sync.com': 1,
'parrable.com': 1,
'digitru.st': 1,
'liveintent.com': 1
};
request.userIdAsEids.forEach(function(eid) {
Expand Down
1 change: 1 addition & 0 deletions test/spec/modules/conversantBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,7 @@ describe('Conversant adapter tests', function() {
expect(bid).to.have.property('creativeId', '1000');
expect(bid).to.have.property('width', 300);
expect(bid).to.have.property('height', 250);
expect(bid.meta.advertiserDomains).to.deep.equal(['https://example.com']);
expect(bid).to.have.property('ad', 'markup000<img src="notify000" />');
expect(bid).to.have.property('ttl', 300);
expect(bid).to.have.property('netRevenue', true);
Expand Down