Rule enforcement: support for floors must include the floors module

[patmmccann]

Type of change

• Other

Description of change

Enforcement of #6465 for #5966 release

I have tried to remove floor support for recently maintained adapters when possible, otherwise adapters were removed.

[lgtm-com]

This pull request fixes 3 alerts when merging fde4b7f into d34bd45 - view on LGTM.com

fixed alerts:

• 2 for Useless conditional
• 1 for Useless assignment to local variable

[lgtm-com]

This pull request fixes 3 alerts when merging 45eab11 into 61c494a - view on LGTM.com

fixed alerts:

• 2 for Useless conditional
• 1 for Useless assignment to local variable

[lgtm-com]

This pull request fixes 3 alerts when merging ce1f527 into c8058a6 - view on LGTM.com

fixed alerts:

• 2 for Useless conditional
• 1 for Useless assignment to local variable

[robertrmartinez]

What happened to this file

test/spec/modules/smilewantedBidAdapter_spec.js

Looks like it was renamed to

test/spec/smilewantedBidAdapter_spec.js

Which is not correct I believe.

Very last change of files when I look at it:

[patmmccann]

What happened to this file

test/spec/modules/smilewantedBidAdapter_spec.js

Looks like it was renamed to

test/spec/smilewantedBidAdapter_spec.js

Which is not correct I believe.

Very last change of files when I look at it:

fixed ty

[robertrmartinez]

I counted

• 29 modules removed
• 26 Spec files removed

I may have missed something but should this be equal number?

[patmmccann]

Not every module had a spec file

[robertrmartinez]

Also I just realized I double counted some because the .md file!

[robertrmartinez]

Looks good.

The changes where we removed the ability to pass a floor, but just set it to default is what we want for sure right?

Seems like the right thing imo.

Thanks this was a lot of work I am sure!

[lgtm-com]

This pull request fixes 3 alerts when merging 2eb6a4c into c8058a6 - view on LGTM.com

fixed alerts:

• 2 for Useless conditional
• 1 for Useless assignment to local variable

[patmmccann]

We're hoping those adapters, eg spotx, add support shortly. The only other option I can think of is removing them, so I tried for any adapter that seemed recently maintained to set the default. The deletions are almost all not maintained. The couple exceptions to that are okay with deprecations (eg sortable).