Widespace Bid Adapter: Support Adomain for prebid 5.0 #6989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
requested changes
Jun 9, 2021
patmmccann
requested changes
Jun 9, 2021
| @@ -95,10 +95,9 @@ export const spec = { | |||
|
|
|||
| // Include debug data when available | |||
| if (!isInHostileIframe) { | |||
| const DEBUG_AD = (find(window.top.location.hash.split('&'), | |||
| data.forceAdId = (find(window.top.location.hash.split('&'), | |||
There was a problem hiding this comment.
please also fix line 64 above to solve #6465
There was a problem hiding this comment.
feel free to do this on a different pr
There was a problem hiding this comment.
So, should I include this code with the new PR, or just fix the bidfloor issue there?
|
It appears circleci did not run, this is usually because you are following your own project. |
|
I got tests to run |
|
why did you close, this was ready to merge, tests passed |
|
LGTM |
prebidtappx
pushed a commit
to prebidtappx/Prebid.js
that referenced
this pull request
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change