IX Bid Adapter : reading video placement property
#6994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punkiller
changed the title
placement property
|
build failed, restarting. |
AlvaroBrey
pushed a commit
to Parrable/Prebid.js
that referenced
this pull request
Jun 17, 2021
* master: (103 commits) Opt Out Bid Adapter: add new bid adapter (prebid#7029) Dependencies/Testing: update dependencies, npm audit fixes, and bump Browserstack versions (prebid#6828) 5.2.0-pre Prebid.js 5.1.0 IX Bid Adapter : reading video `placement` property (prebid#6994) changing PBS debug flag to boolean (prebid#7035) Ats analytics set sampling rate to 1 percent (prebid#7010) Update sspBC bid adapter (v5.0) (prebid#7002) Gamma Bid Adapter: support adomain for Prebid 5.0 (prebid#7033) Datablocks Bid Adapter : update bid adapter and add 5.0 compliance (prebid#6765) Add microadBidAdapter (prebid#7007) Adf Bid Adapter: add adform alias (prebid#7009) Fixed FPD issue after for Prebid.js 5.0 (prebid#7031) Zeta Ssp Bid Adapter: provide devicetype (prebid#7026) make sizes a variable as the code expects (prebid#7024) VidazooBidAdapter: support for response meta.advertiserDomains (v5.0) (prebid#7022) add uid2 to OpenX Bid Adapter (prebid#7015) Zeta Ssp Bid Adapter: page and domain fields from config (prebid#7019) tappx Bid Adapter: fix wrong requests with undefined params (prebid#7021) RealVu Analytics Adapter: remove "tablet" from device types (prebid#7016) ...
|
Thanks for restarting the build and the suggestion @mkendall07 , I just got back from vacation, so I will create a PR against the legacy branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
To read
placementproperty from video params.If thats not present, set a default
placementOther information