Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codefuel Bid Adapter: bugfixes and remove config import #7647

Merged
merged 23 commits into from
Nov 1, 2021

Conversation

tamirnPerion
Copy link
Contributor

@tamirnPerion tamirnPerion commented Oct 31, 2021

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

omerko and others added 21 commits May 30, 2018 16:36
…r is now optional and not mandatory - undertoneBidAdapter.js

* Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js
…r is now optional and not mandatory - undertoneBidAdapter.js

 * Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js
…r is now optional and not mandatory - undertoneBidAdapter.js

* Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js
@lgtm-com
Copy link

lgtm-com bot commented Oct 31, 2021

This pull request introduces 1 alert when merging 94c2c4b into 388ddee - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@tamirnPerion
Copy link
Contributor Author

Hi @ChrisHuie,
We should have point the bidder-url to prod env.
Can you review and apporve?

Thanks!

@ChrisHuie ChrisHuie changed the title Cf bugfixes Codefuel Bid Adapter: bugfixes and remove config import Nov 1, 2021
@ChrisHuie ChrisHuie self-assigned this Nov 1, 2021
@ChrisHuie ChrisHuie merged commit 2ef2b8e into prebid:master Nov 1, 2021
cpabst pushed a commit to sovrn/Prebid.js that referenced this pull request Jan 10, 2022
* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js

* Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js

* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js

 * Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js

* fix lint issue in undertone adapter spec

* added user sync function to undertone adapter

* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js

* Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js

* added user sync function to undertone adapter

* added user sync function to undertone adapter

* revert package-lock.json

* added user sync function to undertone adapter

* Update undertoneBidAdapter.js

* Update browsers.json

* bugfix bidderurl

* bugfix bidderurl

* bugfix bidderurl

* tests

Co-authored-by: omerko <[email protected]>
Co-authored-by: Omer Koren <[email protected]>
Co-authored-by: AnnaPerion <[email protected]>
Co-authored-by: Oran Hollaender <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants