Shinez Bid Adapter: update adapter to comply with latest Prebid version #8494

Soterix · 2022-05-30T18:52:59Z

Type of change

Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

A refactored version of the Shinez bid adapter.

test parameters for validating bids

var adUnits = [{
        code: 'dfp-video-div',
        sizes: [
            [640, 480]
        ],
        mediaTypes: {
            video: {
                playerSize: [
                    [640, 480]
                ],
                context: 'instream'
            }
        },
        bids: [{
            bidder: 'shinez',
            params: {
                org: '56f91cd4d3e3660002000033', // Required
                floorPrice: 2.00, // Optional
                placementId: 'shinez-video-test', // Optional
                testMode: true // Optional
            }
        }]
    },
    {
        code: 'dfp-banner-div',
        sizes: [
            [640, 480]
        ],
        mediaTypes: {
            banner: {
                sizes: [
                    [640, 480]
                ]
            }
        },
        bids: [{
            bidder: 'shinez',
            params: {
                org: '56f91cd4d3e3660002000033', // Required
                floorPrice: 2.00, // Optional
                placementId: 'shinez-banner-test', // Optional
                testMode: true // Optional
            }
        }]
    }
];

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer: [email protected]
official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

A link to a PR on the docs repo at: New doc for Shinez Prebid adapter prebid.github.io#3808

Other information

Soterix · 2022-06-06T12:33:33Z

PR was created 7 days ago, could anybody take a look at it, please?

Soterix · 2022-06-07T15:28:21Z

Guys, would anybody take a look at this PR, please?

Soterix · 2022-06-11T20:23:39Z

Rebased on the last state of master, anything else I can do to speed up the review process?

gitsh84 · 2022-06-19T11:58:21Z

Hey, any update re this PR ?

Soterix · 2022-06-20T12:39:59Z

@ChrisHuie could you please update us on how we can get this approved?

ChrisHuie · 2022-06-21T12:56:56Z

@Soterix @gitsh84 my apologies our integration tests didn't seem to run on this pr and we just got Prebid 7 out the door so this looks to have got lost in the shuffle. Can you please give me edit access so I can try and get them to run? They automatically run on new prs but you are likely following your fork of Prebid in CircleCi instead of Prebid itself.

ChrisHuie · 2022-06-21T13:10:57Z

Also, this will now go on Prebid 7. If you want to add it to the maintained Prebid 6 legacy version the branch is here (https://github.com/prebid/Prebid.js/tree/6.29.x-legacy) or once we get this squared away I can add it back to Prebid 6 as well if you like?

Soterix · 2022-06-21T17:33:14Z

@ChrisHuie, thanks for update. Unfortunately, I am not able to allow editing for you because of https://github.com/orgs/github-community/discussions/5634. Instead, I have rebased changes on the last state of the upstream master and fixed failed tests. Is everything ok now?

ChrisHuie · 2022-06-21T20:55:33Z

@Soterix so our CircleCI tests still didn't run on this pr. It has to do with your github account linking to your fork of the project in CircleCI vs the main project. You have to unfollow your fork in CircleCi I beleive. I can just resubmit this pr and the testing should pop up though if you are cool with that? It's a weird issue that pops up occasionally but not common. Likely would be the same for you on the 6 legacy branch though

Soterix · 2022-06-22T04:41:32Z

understand... @ChrisHuie, can you advise where it is possible to change CircleCi configuration (linking)? I have tried to log in to https://app.circleci.com/ with my GitHub account but I can't find anything related to Prebid. Maybe the issue is that fork is not under the personal account but under the organization one? Do we need to allow integration between CircleCi and our organization account?
Alternatively, I can try to do everything from scratch, I mean remove the repository fork, fork again, add an adapter and create a new PR. Do you think it will resolve the issue with CircleCi?

Soterix · 2022-06-23T13:44:42Z

@ChrisHuie, you have mentioned that you can re-submit this PR, which should also be ok for us. Could you please do it?

ChrisHuie · 2022-06-23T18:06:49Z

@ChrisHuie, you have mentioned that you can re-submit this PR, which should also be ok for us. Could you please do it?

Sure. Will submit and copy you both today. Will make 2 prs. One for master and one for Prebid 6 legacy branch.

patmmccann · 2022-06-23T18:33:01Z

modules/shinezBidAdapter.js

+
+  if (bidderRequest && bidderRequest.refererInfo) {
+    generalParams.referrer = deepAccess(bidderRequest, 'refererInfo.referer');
+    generalParams.page_url = config.getConfig('pageUrl') || deepAccess(window, 'location.href');


this isn't valid behavior in 7

just look for site.page

patmmccann · 2022-06-23T18:33:38Z

modules/shinezBidAdapter.js

+  }
+
+  if (bidderRequest && bidderRequest.refererInfo) {
+    generalParams.referrer = deepAccess(bidderRequest, 'refererInfo.referer');


look for site.ref

Hey @patmmccann, as i understand ortb2.site.page and ortb2.site.ref should be for Prebid 7 - right?

Soterix · 2022-06-26T11:50:21Z

@patmmccann, @ChrisHuie updated, and it looks like ci/circleci tests were run on this PR. Can it be merged?

patmmccann

Lgtm

…on (prebid#8494) * Shinez adapter refactored, new Prebid version supported * Endpoints updated for Shinez adapter * Tests fixed for ortb2 in Shinez adapter * ortb2 site.ref and site.page used in Shinez Shinez adapter

Soterix mentioned this pull request Jun 1, 2022

New doc for Shinez Prebid adapter prebid/prebid.github.io#3808

Merged

8 tasks

ChrisHuie changed the title ~~Shinez adapter refactored, new Prebid version supported~~ Shinez Bid Adapter: update adapter to comply with latest Prebid version Jun 8, 2022

ChrisHuie self-requested a review June 8, 2022 14:47

ChrisHuie self-assigned this Jun 8, 2022

ChrisHuie added the feature label Jun 8, 2022

Soterix force-pushed the master branch from ba0435e to 0c3f8c5 Compare June 11, 2022 19:58

ChrisHuie approved these changes Jun 21, 2022

View reviewed changes

ChrisHuie self-requested a review June 21, 2022 12:57

Soterix added 3 commits June 21, 2022 17:59

Shinez adapter refactored, new Prebid version supported

3d58297

Endpoints updated for Shinez adapter

ab69b80

Tests fixed for ortb2 in Shinez adapter

16d114a

Soterix force-pushed the master branch from 0c3f8c5 to 16d114a Compare June 21, 2022 17:21

patmmccann reviewed Jun 23, 2022

View reviewed changes

Soterix requested a review from patmmccann June 24, 2022 14:44

ortb2 site.ref and site.page used in Shinez Shinez adapter

266f9cc

patmmccann merged commit d594516 into prebid:master Jun 26, 2022

patmmccann reviewed Jun 26, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shinez Bid Adapter: update adapter to comply with latest Prebid version #8494

Shinez Bid Adapter: update adapter to comply with latest Prebid version #8494

Soterix commented May 30, 2022 •

edited

Loading

Soterix commented Jun 6, 2022

Soterix commented Jun 7, 2022

Soterix commented Jun 11, 2022

gitsh84 commented Jun 19, 2022

Soterix commented Jun 20, 2022

ChrisHuie commented Jun 21, 2022 •

edited

Loading

ChrisHuie commented Jun 21, 2022 •

edited

Loading

Soterix commented Jun 21, 2022

ChrisHuie commented Jun 21, 2022 •

edited

Loading

Soterix commented Jun 22, 2022 •

edited

Loading

Soterix commented Jun 23, 2022

ChrisHuie commented Jun 23, 2022

patmmccann Jun 23, 2022

patmmccann Jun 23, 2022

patmmccann Jun 23, 2022

Soterix Jun 24, 2022

Soterix commented Jun 26, 2022

patmmccann left a comment

Shinez Bid Adapter: update adapter to comply with latest Prebid version #8494

Shinez Bid Adapter: update adapter to comply with latest Prebid version #8494

Conversation

Soterix commented May 30, 2022 • edited Loading

Type of change

Description of change

Other information

Soterix commented Jun 6, 2022

Soterix commented Jun 7, 2022

Soterix commented Jun 11, 2022

gitsh84 commented Jun 19, 2022

Soterix commented Jun 20, 2022

ChrisHuie commented Jun 21, 2022 • edited Loading

ChrisHuie commented Jun 21, 2022 • edited Loading

Soterix commented Jun 21, 2022

ChrisHuie commented Jun 21, 2022 • edited Loading

Soterix commented Jun 22, 2022 • edited Loading

Soterix commented Jun 23, 2022

ChrisHuie commented Jun 23, 2022

patmmccann Jun 23, 2022

Choose a reason for hiding this comment

patmmccann Jun 23, 2022

Choose a reason for hiding this comment

patmmccann Jun 23, 2022

Choose a reason for hiding this comment

Soterix Jun 24, 2022

Choose a reason for hiding this comment

Soterix commented Jun 26, 2022

patmmccann left a comment

Choose a reason for hiding this comment

Soterix commented May 30, 2022 •

edited

Loading

ChrisHuie commented Jun 21, 2022 •

edited

Loading

ChrisHuie commented Jun 21, 2022 •

edited

Loading

ChrisHuie commented Jun 21, 2022 •

edited

Loading

Soterix commented Jun 22, 2022 •

edited

Loading