Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdUp Technology bid adapter: add support for floor prices #8507

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

MichaelErmer
Copy link
Contributor

@MichaelErmer MichaelErmer commented Jun 1, 2022

Type of change

  • Feature

Description of change

  • added support for prebid floor module
  • test parameters for validating bids
var adUnits = [
   {
        code: "example1",
        mediaTypes: {
            banner: {
                sizes: [[300, 250], [300, 600]],
            }
        },
        bids: [{
            bidder: "aduptech",
            params: {
                publisher: "prebid",
                placement: "12345"
            }
        }]
   }
];

Be sure to test the integration with your adserver using the Hello World sample page.

  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@MichaelErmer
Copy link
Contributor Author

How can I rerun the tests which failed at some other adapter?

Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@musikele musikele merged commit 5f9d9d0 into prebid:master Jun 9, 2022
@dgirardi
Copy link
Collaborator

dgirardi commented Jun 9, 2022

#8548 fixes a test failure brought about by merging this with prebid 7.

renebaudisch pushed a commit to renebaudisch/Prebid.js that referenced this pull request Jun 28, 2022
bwhisp pushed a commit to bwhisp/Prebid.js that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants