Sonobi Bid Adapter: fix gpid bid request value and add media type value #8541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmed when adding gpid. Added new media type value to the bid request.
ChrisHuie
changed the title
mmoschovas
reviewed
Jun 16, 2022
mmoschovas
reviewed
Jun 16, 2022
mmoschovas
requested changes
Jun 16, 2022
mmoschovas
approved these changes
Jun 22, 2022
renebaudisch
pushed a commit
to renebaudisch/Prebid.js
that referenced
this pull request
Jun 28, 2022
…ue (prebid#8541) * Fixed an issue where the key_maker value in the bid request was malformed when adding gpid. Added new media type value to the bid request. * changed a few if statements to avoid running some conditions when not needed
jlaso
pushed a commit
to AuDigent/Prebid.js
that referenced
this pull request
Jul 1, 2022
…ue (prebid#8541) * Fixed an issue where the key_maker value in the bid request was malformed when adding gpid. Added new media type value to the bid request. * changed a few if statements to avoid running some conditions when not needed
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
…ue (prebid#8541) * Fixed an issue where the key_maker value in the bid request was malformed when adding gpid. Added new media type value to the bid request. * changed a few if statements to avoid running some conditions when not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the key_maker value in the bid request was malformed when adding gpid. Added new media type value to the bid request.
Type of change
Description of change
This change fixes an issue where the key_maker value in the bid request was malformed. It should be a csv of values after the sizes. Additionally, added a value to determine if the bid is display or video.
Be sure to test the integration with your adserver using the Hello World sample page.