Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ras Bid Adapter: Initial release #8551

Merged
merged 5 commits into from
Jul 14, 2022
Merged

Conversation

wsusrasp
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
var adUnits = [{
  code: 'test-div-ad',
  mediaTypes: {
    banner: {
      sizes: [[300, 250], [300, 600]]
    }
  },
  bids: [{
    bidder: 'ras',
    params: {
      network: '4178463',
      site: 'test',
      area: 'areatest',
      slot: 'slot'
    }
  }]
}];

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer: [email protected]
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@wsusrasp wsusrasp force-pushed the add-ras-bid-adapter branch 5 times, most recently from 8f09b1c to c32f941 Compare June 14, 2022 10:52
@patmmccann patmmccann requested a review from lksharma June 14, 2022 11:12
Copy link
Collaborator

@lksharma lksharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wsusrasp,

Before changes can be merged into master they need to meet at least 80% unit test coverage. Can you update your test cases to increase your test coverage?

modules/rasBidAdapter.js Outdated Show resolved Hide resolved
modules/rasBidAdapter.js Outdated Show resolved Hide resolved
@wsusrasp
Copy link
Contributor Author

Hi @lksharma, thank you for your review, I have corrected the problems outlined and updated the tests. The gulp review-start shows coverage of about 95%, please let me know if there is anything else I should do.

modules/rasBidAdapter.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@lksharma lksharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wsusrasp,

Thank you for the changes. I left some additional feedback for some minor changes.

@wsusrasp wsusrasp force-pushed the add-ras-bid-adapter branch 3 times, most recently from d07750a to 29023be Compare July 8, 2022 07:12
Copy link
Collaborator

@lksharma lksharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lksharma
Copy link
Collaborator

@wsusrasp Change LGTM. You can now open a PR in the headerbid-expert repository to have your adapter recognized by the Headerbid Expert extension.

@lksharma lksharma merged commit c99e849 into prebid:master Jul 14, 2022
ahmadlob referenced this pull request in taboola/Prebid.js Jul 27, 2022
* Ras Bid Adapter: Initial release

* * Ras Bid Adapter: "du" and "pos" params

* * Ras Bid Adapter: "pos" param is not supported

* switch to new refererInfo format

* * Ras Bid Adapter: "du" and "dr" params

Co-authored-by: skoklowski <[email protected]>
@wsusrasp wsusrasp deleted the add-ras-bid-adapter branch May 20, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants