-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ras Bid Adapter: Initial release #8551
Conversation
8f09b1c
to
c32f941
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wsusrasp,
Before changes can be merged into master they need to meet at least 80% unit test coverage. Can you update your test cases to increase your test coverage?
c32f941
to
7e8a5dd
Compare
Hi @lksharma, thank you for your review, I have corrected the problems outlined and updated the tests. The gulp review-start shows coverage of about 95%, please let me know if there is anything else I should do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wsusrasp,
Thank you for the changes. I left some additional feedback for some minor changes.
d07750a
to
29023be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wsusrasp Change LGTM. You can now open a PR in the headerbid-expert repository to have your adapter recognized by the Headerbid Expert extension. |
* Ras Bid Adapter: Initial release * * Ras Bid Adapter: "du" and "pos" params * * Ras Bid Adapter: "pos" param is not supported * switch to new refererInfo format * * Ras Bid Adapter: "du" and "dr" params Co-authored-by: skoklowski <[email protected]>
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information