Gumgum Bid Adapter: prebid changes to support jp products #8552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gumgum - ADTS-175 Support multiple GG params
…-support-jp-products ADJS-1165-prebid-adaptor-changes-to-support-jp-products
3 tasks
ChrisHuie
changed the title
|
@patmmccann @gwhigs @ChrisHuie bumping for review. It's been 2 weeks since I opened the PR. |
gwhigs
approved these changes
Jun 21, 2022
|
@gwhigs thank you for reviewing! |
renebaudisch
pushed a commit
to renebaudisch/Prebid.js
that referenced
this pull request
Jun 28, 2022
* Gumgum - ADTS-175 Support multiple GG params * ADJS-1165-prebid-adaptor-changes-to-support-jp-products * made tweaks to the skin product for the gumgumBidAdapter * added test for new product id Co-authored-by: Lisa Benmore <[email protected]> Co-authored-by: John Bauzon <[email protected]>
jlaso
pushed a commit
to AuDigent/Prebid.js
that referenced
this pull request
Jul 1, 2022
* Gumgum - ADTS-175 Support multiple GG params * ADJS-1165-prebid-adaptor-changes-to-support-jp-products * made tweaks to the skin product for the gumgumBidAdapter * added test for new product id Co-authored-by: Lisa Benmore <[email protected]> Co-authored-by: John Bauzon <[email protected]>
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
* Gumgum - ADTS-175 Support multiple GG params * ADJS-1165-prebid-adaptor-changes-to-support-jp-products * made tweaks to the skin product for the gumgumBidAdapter * added test for new product id Co-authored-by: Lisa Benmore <[email protected]> Co-authored-by: John Bauzon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added new product id for skins
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Update gumgum prebid docs prebid.github.io#3839