Newspassid Bid Adapter: initial release

[newspassid-prebid]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

New Bid Adapter: newspassid

• test parameters for validating bids

//Banner adUnit

adUnits = [{
                    code: 'id-of-your-banner-div',
			        mediaTypes: {
			          banner: {
			            sizes: [[300, 250], [300,600]]
			          }
			        },
                    bids: [{
                        bidder: 'newspass',
                        params: {
                            publisherId: 'NEWSPASS0001', /* an ID to identify the publisher account  - required */
                            siteId: '4204204201', /* An ID used to identify a site within a publisher account - required */
                            placementId: '8000000015', /* an ID used to identify the piece of inventory - required - for appnexus test use 13144370. */
							customData: [{"settings": {}, "targeting": {"key": "value", "key2": ["value1", "value2"]}}],/* optional array with 'targeting' placeholder for passing publisher specific key-values for targeting. */                            
                        }
                    }]
                }];

• contact email of the adapter’s maintainer:
  [email protected]

• official adapter submission

[patmmccann]

you double added the spec file

[Rothalack]

Hey @newspassid-prebid, you need to create a .md file for this. It's basically the same as the .md file you did over here prebid/prebid.github.io#3849. The .md file needs to be here in /modules/newspassidBidAdapter.md

I noticed in that docs PR, for the bidder code you put 'newspass' and it needs to be 'newspassid'. I noticed this when trying to run it on the test page and it says newspass bidder doesn't exist.

[newspassid-prebid]

Thanks @Rothalack - I've added the md file to the modules folder as requested. The .md file has newspassid defined as the biddercode so should be correct & I've updated the original test params bidder code to reference the correct bidder code.

[Rothalack]

I see you updated the docs PR .md file correctly. I do not see an update here on this PR to add the .md file in this repo. It sounds like you have added it on your end, maybe you just need to push the commit?

[newspassid-prebid]

I see you updated the docs PR .md file correctly. I do not see an update here on this PR to add the .md file in this repo. It sounds like you have added it on your end, maybe you just need to push the commit?

yeap - my bad - just done!

[newspassid-prebid]

hi @Rothalack @patmmccann - any feedback - had pushed an update last week and requested a re-review - not sure if we need to do anything else - please advise ?

[Rothalack]

It looks good to me, working in testing. I'll give Pat some time to respond.

[newspassid-prebid]

@patmmccann - noticing the circle CI tests are failing - not sure why - its refusing to import chai so not sure this is down to something I've done - the edits committed shouldn't have caused any these issues ?

[AskRupert-DM]

tried recommitting my files - the circleCI tests removed the 'Restoring Cache' error but I'm still seeing errors on the Browserstack test - there's import failures being logged for standard modules/files which I don't think is caused by the spec files per say. Let us know your thoughts when you can @Rothalack @patmmccann