33accross Bid Adapter: add 33across_mgni alias #8570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
changed the title
|
Please cover with a test |
Added tests to cover |
anthonyjl92
changed the title
ChrisHuie
approved these changes
Jun 21, 2022
renebaudisch
pushed a commit
to renebaudisch/Prebid.js
that referenced
this pull request
Jun 28, 2022
* add 33across_mgni alias, remove BIDDER_CODE validation * remove comment * add tests for alias 33across_mgni * fix lint no empty multi line * add alias validation and readded BIDDER_CODE validation * made validation more readable Co-authored-by: Anthony Lin <[email protected]>
jlaso
pushed a commit
to AuDigent/Prebid.js
that referenced
this pull request
Jul 1, 2022
* add 33across_mgni alias, remove BIDDER_CODE validation * remove comment * add tests for alias 33across_mgni * fix lint no empty multi line * add alias validation and readded BIDDER_CODE validation * made validation more readable Co-authored-by: Anthony Lin <[email protected]>
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
* add 33across_mgni alias, remove BIDDER_CODE validation * remove comment * add tests for alias 33across_mgni * fix lint no empty multi line * add alias validation and readded BIDDER_CODE validation * made validation more readable Co-authored-by: Anthony Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
-Added alias '33across_mgni'
-Added validation for alias '33across_mgni'
-Updated tests for biddername validation
Be sure to test the integration with your adserver using the Hello World sample page.
contact email of the adapter’s maintainer
[email protected]
official adapter submission
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information