Criteo Bid Adapter: add iframe syncs support #8577
Conversation
|
Please note your failing test @afewcc |
leonardlabat
force-pushed
the
criteo_sync_iframe
branch
from
207219b
to
2d09a84
Compare
|
Hello @ChrisHuie |
Should be able to review it in the next couple of days |
modules/criteoBidAdapter.js
Outdated
| version: '$prebid.version$'.replace(/\./g, '_'), | ||
| }; | ||
|
|
||
| window.addEventListener('message', function (event) { |
There was a problem hiding this comment.
this leaves a dangling listener each time it's run; imo it should detach itself when it gets the matching requestId back
There was a problem hiding this comment.
I'm also curious: how does the sync figure out which window to message? this is the first time I see this approach and I'm wondering if it needs support from core for the general case (where prebid might be in a window other than top).
There was a problem hiding this comment.
From the sync frame, we simply try to send the message to window.parent (which should be the one listening to the message as it's the one which dropped the frame)
modules/criteoBidAdapter.js
Outdated
| storage.removeDataFromLocalStorage(name); | ||
| } | ||
|
|
||
| function hasPurpose1Consent(gdprConsent) { |
There was a problem hiding this comment.
You could use this utility:
Line 9 in 0be4560
| const refererInfo = getRefererInfo(); | ||
| const origin = 'criteoPrebidAdapter'; | ||
|
|
||
| if (syncOptions.iframeEnabled && hasPurpose1Consent(gdprConsent)) { |
There was a problem hiding this comment.
Prebid.js/modules/pubmaticBidAdapter.js
Line 1300 in 0be4560
why are you putting all this code in the adapter instead of the iframe you return
There was a problem hiding this comment.
i see, you are trying to decorate the sync call with these id's, nevermind
There was a problem hiding this comment.
Regarding the hasPurpose1Consent call
We really want the purpose1 to be granted prior to init our user sync as it involves interacting with 1PC the LS to resolve our sync endpoint arguments.
leonardlabat
force-pushed
the
criteo_sync_iframe
branch
from
2d09a84
to
fcbab99
Compare
Co-authored-by: le.labat <[email protected]>
Co-authored-by: le.labat <[email protected]>
Co-authored-by: le.labat <[email protected]>
Type of change
Description of change
Added support for user sync through iframe as possible sync option
Contacts