Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sovrn: Update adapter to remove tpids and how it gets sizes #8581

Merged
merged 5 commits into from
Jun 21, 2022

Conversation

TWrightSovrn
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Removed setting tpids and updated video code to use sizes if it is there before videoPlayer sizes, else use videoPlayer sizes.

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@Fawke Fawke merged commit 0727222 into prebid:master Jun 21, 2022
@Fawke Fawke added LGTM and removed needs review labels Jun 21, 2022
renebaudisch pushed a commit to renebaudisch/Prebid.js that referenced this pull request Jun 28, 2022
)

* Remove tpids and check for sizes

* Change for tests

* Update code to put back eids and fix tests

* fix: [EX-3771] Fix imports after merge.
bwhisp pushed a commit to bwhisp/Prebid.js that referenced this pull request Jul 13, 2022
)

* Remove tpids and check for sizes

* Change for tests

* Update code to put back eids and fix tests

* fix: [EX-3771] Fix imports after merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants