Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging module: multiple bugfixes #8582

Merged
merged 5 commits into from
Jun 30, 2022
Merged

Conversation

dgirardi
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

  • Fix a bug where debugging configuration would only be retrieved from session storage if the debugging module was not included in the build
  • Fix a bug where building a "-pre" version of Prebid would cause it to fetch a version of 'debugging-standalone.js' that does not exist yet
  • Fix a bug where arrays in the then portion of a rule would be converted to objects
  • Add a --dist-url-base CLI option to allow overriding of the debugging-standalone URL

@ChrisHuie ChrisHuie self-requested a review June 30, 2022 11:04
@ChrisHuie ChrisHuie self-assigned this Jun 30, 2022
@ChrisHuie ChrisHuie merged commit ac62d04 into prebid:master Jun 30, 2022
jlaso pushed a commit to AuDigent/Prebid.js that referenced this pull request Jul 1, 2022
* Debugging module: fix bug with configuration not being loaded from session if module is included in the prebid bundle

* Translate '<version>-pre' to 'latest', not '<version>'

* Add CLI option to set url base for debugging-standalone.js

* Allow arrays in 'then' specification
bwhisp pushed a commit to bwhisp/Prebid.js that referenced this pull request Jul 13, 2022
* Debugging module: fix bug with configuration not being loaded from session if module is included in the prebid bundle

* Translate '<version>-pre' to 'latest', not '<version>'

* Add CLI option to set url base for debugging-standalone.js

* Allow arrays in 'then' specification
ahmadlob referenced this pull request in taboola/Prebid.js Jul 27, 2022
* Debugging module: fix bug with configuration not being loaded from session if module is included in the prebid bundle

* Translate '<version>-pre' to 'latest', not '<version>'

* Add CLI option to set url base for debugging-standalone.js

* Allow arrays in 'then' specification
RomainLofaso pushed a commit to criteo-forks/Prebid.js that referenced this pull request Aug 8, 2022
* Debugging module: fix bug with configuration not being loaded from session if module is included in the prebid bundle

* Translate '<version>-pre' to 'latest', not '<version>'

* Add CLI option to set url base for debugging-standalone.js

* Allow arrays in 'then' specification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants