Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taboola Bid Adapter: update documentation and bid response TTL #8615

Merged
merged 93 commits into from
Jul 6, 2022
Merged

Taboola Bid Adapter: update documentation and bid response TTL #8615

merged 93 commits into from
Jul 6, 2022

Conversation

jennylt
Copy link
Contributor

@jennylt jennylt commented Jun 28, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  1. updating Taboola adapter documentation
  2. changing bid response TTL from 360 to 60 seconds

mikizi and others added 30 commits February 7, 2022 12:18
@mikizi
create taboola adapter
478dc6b
@mikizi
create taboola adapter md
bb75997
@mikizi
taboolaBidAdapter.js - small fixes
a8fe097 
taboolaBidAdapter_spec.js - new UT
@mikizi
taboolaBidAdapter.js - small fixes
6314750 
taboolaBidAdapter_spec.js - new UT
@mikizi
update the md
644ba0f
@mikizi
update the Maintainer email
b09a481
@mikizi
* update MD page
0f11f67 
* refactor code for better readability
* small fix in UT
@mikizi
* add privacy to the request builder
90b0258 
* add relevant Ut
* small fixes in UT
@mikizi
Merge branch 'master' of https://github.com/prebid/Prebid.js into add…
7b1001c 
…-taboola-bid-adapter

Merge from prebid
@mikizi
Merge branch 'master' of https://github.com/taboola/Prebid.js into ad…
7562ed1 
…d-taboola-bid-adapter
@mikizi
* code refactoring + add more accurate way to get page url and referer
de81396 
* add relevant Ut
* small fixes in md
@mikizi
* code refactoring + gte user id
a1dfd88 
* add relevant Ut
* small fixes
@mikizi
* code refactoring + gte user id
600a9d0 
* add relevant Ut
* small fixes
@mikizi
* update end point url
7fb1379 
* update UT
* Update banner End point structure
@mikizi
small fixes + update epi url
0cf48ad
@mikizi
Merge pull request #1 from taboola/add-taboola-bid-adapter
2e81b9b 
Add taboola bid adapter
@mikizi
Merge branch 'master' of https://github.com/prebid/Prebid.js
7f7a0bc
@mikizi
remove the destruction from the bidResponse property
e6e0235
@mikizi
(update the unit tests) remove the destruction from the bidResponse p…
1dabc41 
…roperty
@mikizi
fix tests
4e4ff4a
@mikizi
fix tests - run stubs on each test
9f97222
@mikizi
rerun because of another adapter flaky test
40a0cf6
@mikizi
rerun because of another adapter flaky test
07a1508
@mikizi
fix cors issue, switch between height, width position
6f73485
@mikizi
update badv, bcat to be based in the ortb2 to support prebid 7 new pr…
c13e0c2 
…otocols + update Ut
@mikizi
retry run circleci
1a81f33
@mikizi
retry run circleci
425281f
@mikizi
Merge branch 'master' of https://github.com/prebid/Prebid.js
fe9ba64
@mikizi
pull from upstream
3196a74 
update md (placement + pub )
@mikizi
update badv, bcat UT
637c11f
jennylt and others added 14 commits June 27, 2022 10:43
@jennylt
Merge branch 'master' of https://github.com/prebid/Prebid.js into master
0bf72b6 
� Conflicts:
�	modules/taboolaBidAdapter.js
�	test/spec/modules/taboolaBidAdapter_spec.js
@jennylt
Merge remote-tracking branch 'origin/master' into master
5d99fc9
@jennylt
Merge branch 'master' of https://github.com/taboola/Prebid.js into Fi…
3f0ff10 
…x_Taboola_Prebid_documentation
@mikizi
Merge pull request #2 from taboola/Fix_Taboola_Prebid_documentation
b649c44 
Update taboola prebid documentation
@jennylt
Merge branch 'master' of https://github.com/prebid/Prebid.js into master
8ac1d72
@jennylt
Merge branch 'master' of https://github.com/taboola/Prebid.js into Up…
c35b648 
…date_Bid_Response_TTL
@jennylt
update bid response ttl to 60 seconds.
40ac5a9
@jennylt
Merge remote-tracking branch 'origin/master' into master
6852a4e
@jennylt
Merge branch 'master' of https://github.com/taboola/Prebid.js into Up…
e1b1637 
…date_Bid_Response_TTL
@jennylt
Merge pull request #3 from taboola/Update_Bid_Response_TTL
207ec18 
Update bid response ttl
@jennylt
Merge branch 'master' of https://github.com/prebid/Prebid.js into master
34a00fa
@jennylt
Merge remote-tracking branch 'origin/master' into master
2997122
@jennylt
update Taboola prebid documentation.
0e3919b
@jennylt
Merge pull request #4 from taboola/Update_documentation
bacf5b7 
update Taboola prebid documentation.
@jennylt jennylt mentioned this pull request Jun 28, 2022
Merged
8 tasks
@ChrisHuie ChrisHuie changed the title Updating Taboola documentation and bid response TTL Taboola Bid Adapter: update documentation and bid response TTL Jun 28, 2022
patmmccann
patmmccann previously requested changes Jun 28, 2022
View reviewed changes
modules/taboolaBidAdapter.js Show resolved Hide resolved
@patmmccann patmmccann self-assigned this Jun 28, 2022
@jennylt jennylt requested a review from patmmccann June 29, 2022 13:45
@ChrisHuie ChrisHuie dismissed patmmccann’s stale review July 6, 2022 10:41

Resolved and approved

@ChrisHuie ChrisHuie merged commit e3a0e78 into prebid:master Jul 6, 2022
bwhisp pushed a commit to bwhisp/Prebid.js that referenced this pull request Jul 13, 2022
@jennylt @mikizi @bwhisp
Taboola Bid Adapter: update documentation and bid response TTL (prebi…
e3b40e9 
…d#8615)

* create taboola adapter

* create taboola adapter md

* taboolaBidAdapter.js - small fixes
taboolaBidAdapter_spec.js - new UT

* taboolaBidAdapter.js - small fixes
taboolaBidAdapter_spec.js - new UT

* update the md

* update the Maintainer email

* * update MD page
* refactor code for better readability
* small fix in UT

* * add privacy to the request builder
* add relevant Ut
* small fixes in UT

* * code refactoring + add more accurate way to get page url and referer
* add relevant Ut
* small fixes in md

* * code refactoring + gte user id
* add relevant Ut
* small fixes

* * code refactoring + gte user id
* add relevant Ut
* small fixes

* * update end point url
* update UT
* Update banner End point structure

* small fixes + update epi url

* remove the destruction from the bidResponse property

* (update the unit tests) remove the destruction from the bidResponse property

* fix tests

* fix tests - run stubs on each test

* rerun because of another adapter flaky test

* rerun because of another adapter flaky test

* fix cors issue, switch between height, width position

* update badv, bcat to be based in the ortb2 to support prebid 7 new protocols + update Ut

* retry run circleci

* retry run circleci

* pull from upstream
update md (placement + pub )

* update badv, bcat UT

* rerun build

* rerun build

* support storageAllowed restriction on unit tests for prebid 7

* create taboola adapter

* create taboola adapter md

* taboolaBidAdapter.js - small fixes
taboolaBidAdapter_spec.js - new UT

* taboolaBidAdapter.js - small fixes
taboolaBidAdapter_spec.js - new UT

* update the md

* update the Maintainer email

* * update MD page
* refactor code for better readability
* small fix in UT

* * add privacy to the request builder
* add relevant Ut
* small fixes in UT

* * code refactoring + add more accurate way to get page url and referer
* add relevant Ut
* small fixes in md

* * code refactoring + gte user id
* add relevant Ut
* small fixes

* * code refactoring + gte user id
* add relevant Ut
* small fixes

* * update end point url
* update UT
* Update banner End point structure

* small fixes + update epi url

* remove the destruction from the bidResponse property

* (update the unit tests) remove the destruction from the bidResponse property

* fix tests

* fix tests - run stubs on each test

* rerun because of another adapter flaky test

* rerun because of another adapter flaky test

* fix cors issue, switch between height, width position

* update badv, bcat to be based in the ortb2 to support prebid 7 new protocols + update Ut

* retry run circleci

* retry run circleci

* pull from upstream
update md (placement + pub )

* update badv, bcat UT

* rerun build

* rerun build

* support storageAllowed restriction on unit tests for prebid 7

* support storageAllowed restriction on unit tests for prebid 7

* add it also to the aftereach

* add it also to the aftereach

* change the api endpoint https protocol

* update Taboola prebid documentation:
tagId, publisherId, bidFloor.

* update bid response ttl to 60 seconds.

* update Taboola prebid documentation.

* Fix response test

Co-authored-by: Michael <[email protected]>
Co-authored-by: mikiz <[email protected]>
RomainLofaso pushed a commit to criteo-forks/Prebid.js that referenced this pull request Aug 8, 2022
@jennylt @mikizi @RomainLofaso
Taboola Bid Adapter: update documentation and bid response TTL (prebi…
7cb8883 
…d#8615)

* create taboola adapter

* create taboola adapter md

* taboolaBidAdapter.js - small fixes
taboolaBidAdapter_spec.js - new UT

* taboolaBidAdapter.js - small fixes
taboolaBidAdapter_spec.js - new UT

* update the md

* update the Maintainer email

* * update MD page
* refactor code for better readability
* small fix in UT

* * add privacy to the request builder
* add relevant Ut
* small fixes in UT

* * code refactoring + add more accurate way to get page url and referer
* add relevant Ut
* small fixes in md

* * code refactoring + gte user id
* add relevant Ut
* small fixes

* * code refactoring + gte user id
* add relevant Ut
* small fixes

* * update end point url
* update UT
* Update banner End point structure

* small fixes + update epi url

* remove the destruction from the bidResponse property

* (update the unit tests) remove the destruction from the bidResponse property

* fix tests

* fix tests - run stubs on each test

* rerun because of another adapter flaky test

* rerun because of another adapter flaky test

* fix cors issue, switch between height, width position

* update badv, bcat to be based in the ortb2 to support prebid 7 new protocols + update Ut

* retry run circleci

* retry run circleci

* pull from upstream
update md (placement + pub )

* update badv, bcat UT

* rerun build

* rerun build

* support storageAllowed restriction on unit tests for prebid 7

* create taboola adapter

* create taboola adapter md

* taboolaBidAdapter.js - small fixes
taboolaBidAdapter_spec.js - new UT

* taboolaBidAdapter.js - small fixes
taboolaBidAdapter_spec.js - new UT

* update the md

* update the Maintainer email

* * update MD page
* refactor code for better readability
* small fix in UT

* * add privacy to the request builder
* add relevant Ut
* small fixes in UT

* * code refactoring + add more accurate way to get page url and referer
* add relevant Ut
* small fixes in md

* * code refactoring + gte user id
* add relevant Ut
* small fixes

* * code refactoring + gte user id
* add relevant Ut
* small fixes

* * update end point url
* update UT
* Update banner End point structure

* small fixes + update epi url

* remove the destruction from the bidResponse property

* (update the unit tests) remove the destruction from the bidResponse property

* fix tests

* fix tests - run stubs on each test

* rerun because of another adapter flaky test

* rerun because of another adapter flaky test

* fix cors issue, switch between height, width position

* update badv, bcat to be based in the ortb2 to support prebid 7 new protocols + update Ut

* retry run circleci

* retry run circleci

* pull from upstream
update md (placement + pub )

* update badv, bcat UT

* rerun build

* rerun build

* support storageAllowed restriction on unit tests for prebid 7

* support storageAllowed restriction on unit tests for prebid 7

* add it also to the aftereach

* add it also to the aftereach

* change the api endpoint https protocol

* update Taboola prebid documentation:
tagId, publisherId, bidFloor.

* update bid response ttl to 60 seconds.

* update Taboola prebid documentation.

* Fix response test

Co-authored-by: Michael <[email protected]>
Co-authored-by: mikiz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHuie ChrisHuie ChrisHuie approved these changes

@patmmccann patmmccann Awaiting requested review from patmmccann

Assignees

@patmmccann patmmccann

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jennylt @patmmccann @ChrisHuie @mikizi