-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
byData Analytics Adapter : send data on bidwon, update adunit path, & add some test params #8621
byData Analytics Adapter : send data on bidwon, update adunit path, & add some test params #8621
Conversation
This pull request introduces 1 alert when merging 0fb445d into 86399d9 - view on LGTM.com new alerts:
|
0fb445d
to
5a9bec6
Compare
Changes in the PR look good. However, I noticed your adapter is directly accessing localStorage via the window. Within this PR, could you include the change to import StorageManager and use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
… add some test params (prebid#8621) * data on bidwon-adunit path-some test paramets added * update method for query string parameter * removed unpadded space * using StorageManager set/get value on local storage Co-authored-by: Jitendra-quizlet <[email protected]>
… add some test params (#8621) * data on bidwon-adunit path-some test paramets added * update method for query string parameter * removed unpadded space * using StorageManager set/get value on local storage Co-authored-by: Jitendra-quizlet <[email protected]>
… add some test params (prebid#8621) * data on bidwon-adunit path-some test paramets added * update method for query string parameter * removed unpadded space * using StorageManager set/get value on local storage Co-authored-by: Jitendra-quizlet <[email protected]>
Type of change
Description of change