-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relaido Bid Adapter: Add support for bids[].params.video.playerSize #8627
Merged
ChrisHuie
merged 20 commits into
prebid:master
from
relaido:feature/add-support-for-bid-params-video-playersize
Jun 30, 2022
Merged
Relaido Bid Adapter: Add support for bids[].params.video.playerSize #8627
ChrisHuie
merged 20 commits into
prebid:master
from
relaido:feature/add-support-for-bid-params-video-playersize
Jun 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If mediaTypes.video.playerSize does not have a definition, but params.video.playerSize does, allow it.
relaido
changed the title
Relaido Bid Adapter: Add support for bid[].params.video.playerSize
Relaido Bid Adapter: Add support for bids[].params.video.playerSize
Jun 30, 2022
ChrisHuie
approved these changes
Jun 30, 2022
8 tasks
jlaso
pushed a commit
to AuDigent/Prebid.js
that referenced
this pull request
Jul 1, 2022
…rebid#8627) * add relaido adapter * remove event listener * fixed UserSyncs and e.data * fix conflicts * support params.video.playerSize If mediaTypes.video.playerSize does not have a definition, but params.video.playerSize does, allow it. * add support for playerSize is Array[number, Number] Co-authored-by: ishigami_shingo <[email protected]> Co-authored-by: cmertv-sishigami <[email protected]> Co-authored-by: t_bun <[email protected]> Co-authored-by: n.maeura <[email protected]>
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
…rebid#8627) * add relaido adapter * remove event listener * fixed UserSyncs and e.data * fix conflicts * support params.video.playerSize If mediaTypes.video.playerSize does not have a definition, but params.video.playerSize does, allow it. * add support for playerSize is Array[number, Number] Co-authored-by: ishigami_shingo <[email protected]> Co-authored-by: cmertv-sishigami <[email protected]> Co-authored-by: t_bun <[email protected]> Co-authored-by: n.maeura <[email protected]>
ahmadlob
referenced
this pull request
in taboola/Prebid.js
Jul 27, 2022
…#8627) * add relaido adapter * remove event listener * fixed UserSyncs and e.data * fix conflicts * support params.video.playerSize If mediaTypes.video.playerSize does not have a definition, but params.video.playerSize does, allow it. * add support for playerSize is Array[number, Number] Co-authored-by: ishigami_shingo <[email protected]> Co-authored-by: cmertv-sishigami <[email protected]> Co-authored-by: t_bun <[email protected]> Co-authored-by: n.maeura <[email protected]>
RomainLofaso
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Aug 8, 2022
…rebid#8627) * add relaido adapter * remove event listener * fixed UserSyncs and e.data * fix conflicts * support params.video.playerSize If mediaTypes.video.playerSize does not have a definition, but params.video.playerSize does, allow it. * add support for playerSize is Array[number, Number] Co-authored-by: ishigami_shingo <[email protected]> Co-authored-by: cmertv-sishigami <[email protected]> Co-authored-by: t_bun <[email protected]> Co-authored-by: n.maeura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
If
mediaTypes.video.playerSize
does not have a definition, but validbids[].params.video.playerSize
does, allow it.Add support for playerSize is
Array[Number, Number]