Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaido Bid Adapter: Add support for bids[].params.video.playerSize #8627

Conversation

relaido
Copy link
Contributor

@relaido relaido commented Jun 30, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • If mediaTypes.video.playerSize does not have a definition, but valid bids[].params.video.playerSize does, allow it.

    {
      mediaTypes: {
        video: {
          context: 'outstream'
          // Not definition playerSize
        }
      },
      bids: [
        {
          bidder: 'relaido',
          params: {
            placementId: '100000',
            video: {
              playerSize: [
                [640, 360]
              ]
            }
          }
        },
        ...
      ]
    }
    
  • Add support for playerSize is Array[Number, Number]

    {
      mediaTypes: {
        video: {
          context: 'outstream',
          playerSize: [640, 360] // [[640, 360]] also ok
        }
      },
      bids: [
        {
          bidder: 'relaido',
          params: {
            placementId: '100000',
            video: {
              playerSize: [640, 360] // [[640, 360]] also ok
            }
          }
        },
        ...
      ]
    }
    

@relaido relaido changed the title Relaido Bid Adapter: Add support for bid[].params.video.playerSize Relaido Bid Adapter: Add support for bids[].params.video.playerSize Jun 30, 2022
@ChrisHuie ChrisHuie self-requested a review June 30, 2022 10:19
@ChrisHuie ChrisHuie self-assigned this Jun 30, 2022
@ChrisHuie ChrisHuie merged commit 5a3c835 into prebid:master Jun 30, 2022
jlaso pushed a commit to AuDigent/Prebid.js that referenced this pull request Jul 1, 2022
…rebid#8627)

* add relaido adapter

* remove event listener

* fixed UserSyncs and e.data

* fix conflicts

* support params.video.playerSize

If mediaTypes.video.playerSize does not have a definition, but params.video.playerSize does, allow it.

* add support for playerSize is Array[number, Number]

Co-authored-by: ishigami_shingo <[email protected]>
Co-authored-by: cmertv-sishigami <[email protected]>
Co-authored-by: t_bun <[email protected]>
Co-authored-by: n.maeura <[email protected]>
bwhisp pushed a commit to bwhisp/Prebid.js that referenced this pull request Jul 13, 2022
…rebid#8627)

* add relaido adapter

* remove event listener

* fixed UserSyncs and e.data

* fix conflicts

* support params.video.playerSize

If mediaTypes.video.playerSize does not have a definition, but params.video.playerSize does, allow it.

* add support for playerSize is Array[number, Number]

Co-authored-by: ishigami_shingo <[email protected]>
Co-authored-by: cmertv-sishigami <[email protected]>
Co-authored-by: t_bun <[email protected]>
Co-authored-by: n.maeura <[email protected]>
ahmadlob referenced this pull request in taboola/Prebid.js Jul 27, 2022
…#8627)

* add relaido adapter

* remove event listener

* fixed UserSyncs and e.data

* fix conflicts

* support params.video.playerSize

If mediaTypes.video.playerSize does not have a definition, but params.video.playerSize does, allow it.

* add support for playerSize is Array[number, Number]

Co-authored-by: ishigami_shingo <[email protected]>
Co-authored-by: cmertv-sishigami <[email protected]>
Co-authored-by: t_bun <[email protected]>
Co-authored-by: n.maeura <[email protected]>
RomainLofaso pushed a commit to criteo-forks/Prebid.js that referenced this pull request Aug 8, 2022
…rebid#8627)

* add relaido adapter

* remove event listener

* fixed UserSyncs and e.data

* fix conflicts

* support params.video.playerSize

If mediaTypes.video.playerSize does not have a definition, but params.video.playerSize does, allow it.

* add support for playerSize is Array[number, Number]

Co-authored-by: ishigami_shingo <[email protected]>
Co-authored-by: cmertv-sishigami <[email protected]>
Co-authored-by: t_bun <[email protected]>
Co-authored-by: n.maeura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants