Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microad Bid Adapter: Added Support for Audience IDs #8662

Merged
merged 13 commits into from
Jul 25, 2022
Merged

Microad Bid Adapter: Added Support for Audience IDs #8662

merged 13 commits into from
Jul 25, 2022

Conversation

azuma-ryotaro
Copy link
Contributor

@azuma-ryotaro azuma-ryotaro commented Jul 8, 2022 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Support Audience ID below in MicroAd Bid Adapter

contact email of the adapter’s maintainer

  • official adapter submission
  • contact email of the adapter’s maintainer: [email protected]

@ChrisHuie ChrisHuie changed the title Support Audience ID below in MicroAd Bid Adapter Miocroad Bid Adapter: support Audience ID Jul 11, 2022
@ChrisHuie ChrisHuie requested a review from lksharma July 12, 2022 11:54
lksharma
lksharma requested changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@lksharma lksharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azuryo Test coverage must be at least 80%. Please add additional unit tests to the PR.

@azuma-ryotaro
Copy link
Contributor Author

azuma-ryotaro commented Jul 19, 2022 •
edited
Loading

@lksharma

Thanks for the feedback.
Ran gulp test-coverage and results for our adapter state 100% for statements, branches, functions and lines.
For reference, I'm attaching the results from gulp test-coverage and gulp view-coverage.
Am I looking at the results incorrectly? Should I be looking at the results for all files instead?
スクリーンショット 2022-07-19 14 19 06

@lksharma
Copy link
Collaborator

@azuryo that was my mistake your test coverage is 100%.

@lksharma lksharma changed the title Miocroad Bid Adapter: support Audience ID Miocroad Bid Adapter: Added Support for Audience IDs Jul 25, 2022
lksharma
lksharma approved these changes Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@lksharma lksharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lksharma lksharma merged commit b119512 into prebid:master Jul 25, 2022
@azuma-ryotaro azuma-ryotaro changed the title Miocroad Bid Adapter: Added Support for Audience IDs Microad Bid Adapter: Added Support for Audience IDs Jul 26, 2022
ccorbo pushed a commit to ccorbo/Prebid.js that referenced this pull request Jul 27, 2022
@azuma-ryotaro
Miocroad Bid Adapter: Added Support for Audience IDs (prebid#8662)
4b1fece 
* Microad Bid Adapter: Add IM-UID

* Microad Bid Adapter: Add ID5 ID

* Microad Bid Adapter: Add Unified ID

* Microad Bid Adapter: Add Novatiq Hyper ID

* Microad Bid Adapter: Add Parrable ID

* Microad Bid Adapter: Add AudienceOne User ID

* Microad BidAdapter: Add Audience ID spec

* Microad BidAdapter: Add Ramp ID in params

* Microad BidAdapter: Fix Audience ID

* Microad BidAdapter: Add Criteo ID and Shared ID

* Microad BidAdapter: Fix typo

* Microad BidAdapter: Fix variable name
@azuma-ryotaro azuma-ryotaro deleted the microad-audience-ids branch July 29, 2022 02:41
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
@azuma-ryotaro @JacobKlein26
Miocroad Bid Adapter: Added Support for Audience IDs (prebid#8662)
d2edeb6 
* Microad Bid Adapter: Add IM-UID

* Microad Bid Adapter: Add ID5 ID

* Microad Bid Adapter: Add Unified ID

* Microad Bid Adapter: Add Novatiq Hyper ID

* Microad Bid Adapter: Add Parrable ID

* Microad Bid Adapter: Add AudienceOne User ID

* Microad BidAdapter: Add Audience ID spec

* Microad BidAdapter: Add Ramp ID in params

* Microad BidAdapter: Fix Audience ID

* Microad BidAdapter: Add Criteo ID and Shared ID

* Microad BidAdapter: Fix typo

* Microad BidAdapter: Fix variable name
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
@azuma-ryotaro @jorgeluisrocha
Miocroad Bid Adapter: Added Support for Audience IDs (prebid#8662)
7ee214a 
* Microad Bid Adapter: Add IM-UID

* Microad Bid Adapter: Add ID5 ID

* Microad Bid Adapter: Add Unified ID

* Microad Bid Adapter: Add Novatiq Hyper ID

* Microad Bid Adapter: Add Parrable ID

* Microad Bid Adapter: Add AudienceOne User ID

* Microad BidAdapter: Add Audience ID spec

* Microad BidAdapter: Add Ramp ID in params

* Microad BidAdapter: Fix Audience ID

* Microad BidAdapter: Add Criteo ID and Shared ID

* Microad BidAdapter: Fix typo

* Microad BidAdapter: Fix variable name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lksharma lksharma lksharma approved these changes

Assignees

@lksharma lksharma

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azuma-ryotaro @lksharma @ChrisHuie