Ftrack Id Module: adding parameter to callback in getId return object #8678

ftxmoJason · 2022-07-12T16:17:19Z

Type of change

Other

Description of change

Adding a cb parameter to the callback property in the object returned by getId() so that more pbjs get ID methods can be used
Tweaking the eids.js so that a value is returned. We tried to return our IDs as an object but had to JSON.stringify() it.

Removing package-lock.json because it has conflicts and its not on ftrack to change it either way

…rebid.js into ftrack-getid-mods

TheMediaGrid · 2022-07-12T21:42:34Z

@patmmccann any idea on how Flashtalking could return the IDs directly within the uids object of the eids? 'return data' didn't work so @ftxmoJason had to go with json.stringify, but we'd like the structure within uids to be flat and the IDs to be listed right in the JSPN structure

ftxmoJason · 2022-07-12T22:03:57Z

To build on @TheMediaGrid 's comment. Our IDs are formatted like so:

{
    "HHID": ["<USERS HH ID>"],
    "DeviceID": ["<USERS DEVICE ID>"],
    "SingleDeviceID": ["USERS SINGLE DEVICE ID"]
}

And we can't return an object from eids.js getValue, so we JSON.stringify() the object and return it. Is that the best approach?

ftxmoJason · 2022-07-13T14:16:10Z

@ftxmojared Just trying to ping you in this thread for awareness.

patmmccann · 2022-07-13T15:22:56Z

have you studied this #8429

ftxmoJason · 2022-07-13T16:53:49Z

Thanks @patmmccann for the suggestion.
I tweaked the createEidsArray method and added a condition for 'ftrack', similar to how 'pubProvidedId' did it.

smenzer

i did an initial pass through and first thing we need are test cases for the new functionality. also, are there any changes to publisher implementation of the config or does this only impact those reading the EIDs array?

smenzer · 2022-07-13T23:02:25Z

modules/userId/eids.js

+      } else if (subModuleKey === 'ftrackId') {
+        // ftrack has multiple IDs so we add each one that exists
+        let eid = {
+          'atype': 1,
+          'id': (bidRequestUserId[subModuleKey]['DeviceID'] || []).join('|'),
+          'ext': {}
+        }
+        for (let id in bidRequestUserId[subModuleKey]) {
+          eid.ext[id] = (bidRequestUserId[subModuleKey][id] || []).join('|');
+        }
+
+        eids.push(eid);


this block needs tests cases, please

no changes to the publisher config implementation, just the eids object interaction is changed
I will also let @ftxmoJason comment on the test cases

…lated tests

TheMediaGrid · 2022-07-19T20:36:41Z

@smenzer can you please take a look at the updates here? we'd really like this PR to make it to the next release if possible

test/spec/modules/ftrackIdSystem_spec.js

smenzer

LGTM

This probably warrants an update to the prebid docs repository, but I'll go ahead and approve this now since this is good to go.

… (#8678) * Adding cb to the callback * Delete package-lock.json Removing package-lock.json because it has conflicts and its not on ftrack to change it either way * Un conflicting the package-lock * ftrack: getting data to return in the EIDS * ftrack: getting data to return in the EIDS lint * ftrack: making the eids return all IDs * ftrack: making the eids return all IDs * ftrack: tweaking the EID schema per MediaGrid's requests * Added tests for getUserIdsAsEids method * Updated the ftrack decode function with suggested code and updated related tests * Updated getUserIdsAsEids tests to match value directly Co-authored-by: Jason Lydon <[email protected]> Co-authored-by: Jared <[email protected]>

…prebid#8678) * Adding cb to the callback * Delete package-lock.json Removing package-lock.json because it has conflicts and its not on ftrack to change it either way * Un conflicting the package-lock * ftrack: getting data to return in the EIDS * ftrack: getting data to return in the EIDS lint * ftrack: making the eids return all IDs * ftrack: making the eids return all IDs * ftrack: tweaking the EID schema per MediaGrid's requests * Added tests for getUserIdsAsEids method * Updated the ftrack decode function with suggested code and updated related tests * Updated getUserIdsAsEids tests to match value directly Co-authored-by: Jason Lydon <[email protected]> Co-authored-by: Jared <[email protected]>

Jason Lydon and others added 8 commits July 12, 2022 11:56

Adding cb to the callback

7a0a904

Delete package-lock.json

eaf387a

Removing package-lock.json because it has conflicts and its not on ftrack to change it either way

Un conflicting the package-lock

80982d8

package-lock issues

8d8c123

Merge branch 'prebid:master' into ftrack-getid-mods

e15fa86

ftrack: getting data to return in the EIDS

902f593

Merge branch 'ftrack-getid-mods' of https://github.com/Flashtalking/P…

7307be0

…rebid.js into ftrack-getid-mods

ftrack: getting data to return in the EIDS lint

c9a1c14

ChrisHuie changed the title ~~Ftrack getid mods - adding parameter to callback in getId return object~~ Ftrack Id Module: adding parameter to callback in getId return object Jul 13, 2022

ftrack: making the eids return all IDs

f928481

Jason Lydon added 2 commits July 13, 2022 12:55

ftrack: making the eids return all IDs

22fc415

ftrack: tweaking the EID schema per MediaGrid's requests

979bef6

patmmccann requested a review from smenzer July 13, 2022 19:07

patmmccann assigned smenzer Jul 13, 2022

patmmccann added the maintenance label Jul 13, 2022

smenzer requested changes Jul 13, 2022

View reviewed changes

Jared added 2 commits July 15, 2022 15:01

Added tests for getUserIdsAsEids method

d19b004

Updated the ftrack decode function with suggested code and updated re…

c5f02be

…lated tests

smenzer requested changes Jul 20, 2022

View reviewed changes

test/spec/modules/ftrackIdSystem_spec.js Outdated Show resolved Hide resolved

Updated getUserIdsAsEids tests to match value directly

7d2699a

smenzer approved these changes Jul 21, 2022

View reviewed changes

smenzer merged commit f7196dc into prebid:master Jul 21, 2022

dgirardi mentioned this pull request Oct 17, 2022

FTRACK USER ID MODULE: tweaking the createEidsArray() method to accept two schema patterns #9123

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ftrack Id Module: adding parameter to callback in getId return object #8678

Ftrack Id Module: adding parameter to callback in getId return object #8678

ftxmoJason commented Jul 12, 2022 •

edited

Loading

TheMediaGrid commented Jul 12, 2022

ftxmoJason commented Jul 12, 2022

ftxmoJason commented Jul 13, 2022

patmmccann commented Jul 13, 2022

ftxmoJason commented Jul 13, 2022

smenzer left a comment

smenzer Jul 13, 2022

TheMediaGrid Jul 14, 2022

TheMediaGrid commented Jul 19, 2022

smenzer left a comment

Ftrack Id Module: adding parameter to callback in getId return object #8678

Ftrack Id Module: adding parameter to callback in getId return object #8678

Conversation

ftxmoJason commented Jul 12, 2022 • edited Loading

Type of change

Description of change

TheMediaGrid commented Jul 12, 2022

ftxmoJason commented Jul 12, 2022

ftxmoJason commented Jul 13, 2022

patmmccann commented Jul 13, 2022

ftxmoJason commented Jul 13, 2022

smenzer left a comment

Choose a reason for hiding this comment

smenzer Jul 13, 2022

Choose a reason for hiding this comment

TheMediaGrid Jul 14, 2022

Choose a reason for hiding this comment

TheMediaGrid commented Jul 19, 2022

smenzer left a comment

Choose a reason for hiding this comment

ftxmoJason commented Jul 12, 2022 •

edited

Loading