PBS Bid Adapter: Setting bidderCode and adapterCode for a bid #8696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed net revenue to True
Syncing with Upstream
patmmccann
added
the
needs 2nd review
added 2 commits
July 19, 2022 11:21
…id.js into pbs-alternate-bidder
dgirardi
reviewed
Jul 19, 2022
bretg
approved these changes
Jul 20, 2022
dgirardi
approved these changes
Jul 20, 2022
ChrisHuie
removed
needs unit tests
needs 2nd review
ahmadlob
referenced
this pull request
in taboola/Prebid.js
Jul 27, 2022
* Changed net revenue to True * Added bidderCode and adapterCode to bidObject * setting seat as default adapterCode * removed bidderCode * Added unit test cases * cloned the test object Co-authored-by: Azhar <[email protected]>
ccorbo
pushed a commit
to ccorbo/Prebid.js
that referenced
this pull request
Jul 27, 2022
…#8696) * Changed net revenue to True * Added bidderCode and adapterCode to bidObject * setting seat as default adapterCode * removed bidderCode * Added unit test cases * cloned the test object Co-authored-by: Azhar <[email protected]>
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
…#8696) * Changed net revenue to True * Added bidderCode and adapterCode to bidObject * setting seat as default adapterCode * removed bidderCode * Added unit test cases * cloned the test object Co-authored-by: Azhar <[email protected]>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
…#8696) * Changed net revenue to True * Added bidderCode and adapterCode to bidObject * setting seat as default adapterCode * removed bidderCode * Added unit test cases * cloned the test object Co-authored-by: Azhar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
We encountered a warning message on the console, similar to PrebidJS bug when an alternate bidder wins the auction.
Setting the bidderCode and adapterCode of a receiving bid to handle it.