Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IX Bid Adapter : GPID and Bug Fix #8698

Merged
merged 9 commits into from
Jul 18, 2022
Merged

Conversation

ccorbo
Copy link
Contributor

@ccorbo ccorbo commented Jul 18, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Creates GPID when GPID is not already created
Address' issue: #8687

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie ChrisHuie changed the title IX Bid Adapter - GPID and Bug Fix IX Bid Adapter : GPID and Bug Fix Jul 18, 2022
@ChrisHuie ChrisHuie self-requested a review July 18, 2022 13:36
@ChrisHuie ChrisHuie self-assigned this Jul 18, 2022
@patmmccann patmmccann merged commit cd0529a into prebid:master Jul 18, 2022
ahmadlob referenced this pull request in taboola/Prebid.js Jul 27, 2022
* beginning work

* wip

* Build GPID manually when dp_ad_unit_code is present and gpid doesnt already exist

* resolve conflict

* remove pb ad slot

* merge conflict resolved

* fixed video warning

Co-authored-by: Chris Corbo <[email protected]>
Co-authored-by: Love Sharma <[email protected]>
ccorbo added a commit to ccorbo/Prebid.js that referenced this pull request Jul 27, 2022
* beginning work

* wip

* Build GPID manually when dp_ad_unit_code is present and gpid doesnt already exist

* resolve conflict

* remove pb ad slot

* merge conflict resolved

* fixed video warning

Co-authored-by: Chris Corbo <[email protected]>
Co-authored-by: Love Sharma <[email protected]>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
* beginning work

* wip

* Build GPID manually when dp_ad_unit_code is present and gpid doesnt already exist

* resolve conflict

* remove pb ad slot

* merge conflict resolved

* fixed video warning

Co-authored-by: Chris Corbo <[email protected]>
Co-authored-by: Love Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants