Snigel Bid Adapter: initial adapter release

[snigelweb]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

Add snigel bidder adapter.

• test parameters for validating bids

{
  bidder: 'snigel',
  params: {
    placement: 'prebid_test_placement'
  }
}

• contact email of the adapter’s maintainer: [email protected]
• official adapter submission

Other information

PR on prebid.github.io docs repository: prebid/prebid.github.io#3919

[snigelweb]

Sorry for updating the PR, but we discovered an issue with the user sync internally and fixed it. Should be fine now.

[Fawke]

Hi @snigelweb,

This PR looks mostly good. I noticed that in some places, you are using bidderSettings to read some bidder specific values. I think it would be more ideal to use setBidderConfig instead.

I agree BidderSettings does work here, but I think it's more suitable in cases where we want to modify bidder's bids (targeting, cpm, etc,). And setBidderConfig is specially designed to pass bidder specific values.

[snigelweb]

Thanks for your review and the heads-up. We will implement your review feedback along with fixing some issues we came across soon.

[snigelweb]

Hello @Fawke, we implemented the changes you requested and added some additional features while we were at it. Thanks.

[Fawke]

LGTM