Ozone Bid Adapter: Various improvements #8755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added instream support fixed/cleaned up code
|
Not sure why Circle CI tests aren't running - spec file looks okay to me - are you able to advise @patmmccann ? |
|
Typically if you're following your own fork it may not run |
patmmccann
changed the title
|
I added some line breaks to your md file, that seemed to do the trick (bc I don't follow your fork in circleci) |
|
Thanks @patmmccann - good to know ! @ncolletti - let me know if you need anything to help with your review / approving this |
|
Looks good @AskRupert-DM -- Before I merge, could you open a PR with the prebid site repo updating your dev-doc to include instream and relevant bid params: https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/ozone.md |
7 tasks
|
done - thank you! |
|
Docs PR: |
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* ozone adapter 2.8.0 added instream support fixed/cleaned up code * spec test for ozone 2.8.0 adapter * ozone adapter 2.8.0 * Update ozoneBidAdapter_spec.js * Update ozoneBidAdapter.md Co-authored-by: Patrick McCann <[email protected]>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* ozone adapter 2.8.0 added instream support fixed/cleaned up code * spec test for ozone 2.8.0 adapter * ozone adapter 2.8.0 * Update ozoneBidAdapter_spec.js * Update ozoneBidAdapter.md Co-authored-by: Patrick McCann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added Support for instream
Minor code clean ups
[email protected]