Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubMatic Adapter : send device.language in ISO-639-1-alpha-2 (2 character language) format #8789

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

kapil-tuptewar
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Earlier PubMatic Adapter was sending language as navigator.language (e.g. 'en-US') but as per OpenRTB2.5 specification we should pass device.language in ISO-639-1-alpha-2 format which in this case is "en".

@ChrisHuie ChrisHuie self-requested a review August 5, 2022 11:01
@ChrisHuie ChrisHuie self-assigned this Aug 5, 2022
@ChrisHuie ChrisHuie changed the title PubMatic Adapter : Send device.language in ISO-639-1-alpha-2 (2 character language) format PubMatic Adapter : a\send device.language in ISO-639-1-alpha-2 (2 character language) format Aug 5, 2022
@ChrisHuie ChrisHuie changed the title PubMatic Adapter : a\send device.language in ISO-639-1-alpha-2 (2 character language) format PubMatic Adapter : send device.language in ISO-639-1-alpha-2 (2 character language) format Aug 5, 2022
@ChrisHuie ChrisHuie merged commit a93a7c9 into prebid:master Aug 5, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants