Prebid Core : fix issue of mergeConfig #8791
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
We have observed following behaviour during our testing.
When
mergeConfig
is used aftersetConfig
, all the properties which have object as value in the config are merged or get the latest value but the properties which are non-object, are not merged or does not get the latest value.e.g:
After the above statements execution, the value of config object becomes
Here the value of
testObj
is merged buttestProp
isn't.The reason being, when we call
mergeConfig
, it callsmergeDeep
internally on the conflicting properties.Since
mergeDeep
only works for object, we get above behaviour.Solution:
Instead of using a
mergeDeep
on conflicting properties, we have used it on complete object.