Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImproveDigital Bid Adapter: minor bug fixes #9614

Merged
merged 9 commits into from
Mar 3, 2023
Merged

ImproveDigital Bid Adapter: minor bug fixes #9614

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7ab8dd6
Improve Digital adapter: publisher endpoint, addtl consent, syncs (#14)
faisalvs Oct 18, 2022
4972d0e
Resolved conflicts
faisalvs Oct 25, 2022
3348c5d
Code refactored
faisalvs Oct 25, 2022
ba7a3b6
Minor changes
jbartek25 Oct 25, 2022
2124ce5
Merge from upstream master
jbartek25 Oct 25, 2022
37e98ad
Fix an issue where uppercase </SCRIPT> tags broke the JS on page, as …
cciocov Mar 1, 2023
7f5c36f
Merge branch 'prebid:master' into razr-fix
cciocov Mar 2, 2023
2a92881
Merge pull request #19 from ImproveDigital/razr-fix
cciocov Mar 2, 2023
fac257b
fixed tests
cciocov Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/improvedigitalBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ const ID_RAZR = {
}
};

const cfgStr = JSON.stringify(cfg).replace(/<\/script>/g, '\\x3C/script>');
const cfgStr = JSON.stringify(cfg).replace(/<\/script>/ig, '\\x3C/script>');
const s = `<script>window.__razr_config = ${cfgStr};</script>`;
bid.ad = bid.ad.replace(/<body[^>]*>/, match => match + s);

Expand Down
9 changes: 9 additions & 0 deletions test/spec/modules/improvedigitalBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,15 @@ describe('Improve Digital Adapter Tests', function () {
expect(payload.user.ext.consented_providers_settings).to.not.exist;
});

it('should add ConsentedProvidersSettings when extend mode enabled', function () {
const bidRequest = deepClone(extendBidRequest);
const payload = JSON.parse(spec.buildRequests([bidRequest], bidderRequestGdpr)[0].data);
expect(payload.regs.ext.gdpr).to.exist.and.to.equal(1);
expect(payload.user.ext.consent).to.equal('CONSENT');
expect(payload.user.ext.ConsentedProvidersSettings.consented_providers).to.exist.and.to.equal('1~1.35.41.101');
expect(payload.user.ext.consented_providers_settings).to.not.exist;
});

it('should add CCPA consent string', function () {
const bidRequest = Object.assign({}, simpleBidRequest);
const request = spec.buildRequests([bidRequest], syncAddFPDToBidderRequest({...bidderRequest, ...{ uspConsent: '1YYY' }}));
Expand Down