Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NeuwoRtdModule: The global.site.cattax field is not set anymore as it is not defined in openrtb 2.5 #9810

Merged
merged 1 commit into from
Apr 14, 2023
Merged

NeuwoRtdModule: The global.site.cattax field is not set anymore as it is not defined in openrtb 2.5 #9810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions modules/neuwoRtdProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import CONSTANTS from '../src/constants.json';

export const DATA_PROVIDER = 'neuwo.ai';
const SEGTAX_IAB = 6 // IAB - Content Taxonomy version 2
const CATTAX_IAB = 6 // IAB Tech Lab Content Taxonomy 2.2
const RESPONSE_IAB_TIER_1 = 'marketing_categories.iab_tier_1'
const RESPONSE_IAB_TIER_2 = 'marketing_categories.iab_tier_2'

Expand Down Expand Up @@ -106,7 +105,6 @@ export function injectTopics(topics, bidsConfig) {

// upgrade category taxonomy to IAB 2.2, inject result to page categories
if (segment.length > 0) {
addFragment(bidsConfig.ortb2Fragments.global, 'site.cattax', CATTAX_IAB)
addFragment(bidsConfig.ortb2Fragments.global, 'site.pagecat', segment.map(s => s.id))
}

Expand Down
1 change: 0 additions & 1 deletion test/spec/modules/neuwoRtdProvider_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ describe('neuwoRtdProvider', function () {
neuwo.injectTopics(topics, bidsConfig, () => { })
expect(bidsConfig.ortb2Fragments.global.site.content.data[0].name, 'name of first content data object').to.equal(neuwo.DATA_PROVIDER)
expect(bidsConfig.ortb2Fragments.global.site.content.data[0].segment[0].id, 'id of first segment in content.data').to.equal(TAX_ID)
expect(bidsConfig.ortb2Fragments.global.site.cattax, 'category taxonomy code for pagecat').to.equal(6) // CATTAX_IAB
expect(bidsConfig.ortb2Fragments.global.site.pagecat[0], 'category taxonomy code for pagecat').to.equal(TAX_ID)
})

Expand Down